Skip to content
  • Markus Armbruster's avatar
    qapi: New QMP command query-qmp-schema for QMP introspection · 39a18158
    Markus Armbruster authored
    
    
    qapi/introspect.json defines the introspection schema.  It's designed
    for QMP introspection, but should do for similar uses, such as QGA.
    
    The introspection schema does not reflect all the rules and
    restrictions that apply to QAPI schemata.  A valid QAPI schema has an
    introspection value conforming to the introspection schema, but the
    converse is not true.
    
    Introspection lowers away a number of schema details, and makes
    implicit things explicit:
    
    * The built-in types are declared with their JSON type.
    
      All integer types are mapped to 'int', because how many bits we use
      internally is an implementation detail.  It could be pressed into
      external interface service as very approximate range information,
      but that's a bad idea.  If we need range information, we better do
      it properly.
    
    * Implicit type definitions are made explicit, and given
      auto-generated names:
    
      - Array types, named by appending "List" to the name of their
        element type, like in generated C.
    
      - The enumeration types implicitly defined by simple union types,
        named by appending "Kind" to the name of their simple union type,
        like in generated C.
    
      - Types that don't occur in generated C.  Their names start with ':'
        so they don't clash with the user's names.
    
    * All type references are by name.
    
    * The struct and union types are generalized into an object type.
    
    * Base types are flattened.
    
    * Commands take a single argument and return a single result.
    
      Dictionary argument or list result is an implicit type definition.
    
      The empty object type is used when a command takes no arguments or
      produces no results.
    
      The argument is always of object type, but the introspection schema
      doesn't reflect that.
    
      The 'gen': false directive is omitted as implementation detail.
    
      The 'success-response' directive is omitted as well for now, even
      though it's not an implementation detail, because it's not used by
      QMP.
    
    * Events carry a single data value.
    
      Implicit type definition and empty object type use, just like for
      commands.
    
      The value is of object type, but the introspection schema doesn't
      reflect that.
    
    * Types not used by commands or events are omitted.
    
      Indirect use counts as use.
    
    * Optional members have a default, which can only be null right now
    
      Instead of a mandatory "optional" flag, we have an optional default.
      No default means mandatory, default null means optional without
      default value.  Non-null is available for optional with default
      (possible future extension).
    
    * Clients should *not* look up types by name, because type names are
      not ABI.  Look up the command or event you're interested in, then
      follow the references.
    
      TODO Should we hide the type names to eliminate the temptation?
    
    New generator scripts/qapi-introspect.py computes an introspection
    value for its input, and generates a C variable holding it.
    
    It can generate awfully long lines.  Marked TODO.
    
    A new test-qmp-input-visitor test case feeds its result for both
    tests/qapi-schema/qapi-schema-test.json and qapi-schema.json to a
    QmpInputVisitor to verify it actually conforms to the schema.
    
    New QMP command query-qmp-schema takes its return value from that
    variable.  Its reply is some 85KiBytes for me right now.
    
    If this turns out to be too much, we have a couple of options:
    
    * We can use shorter names in the JSON.  Not the QMP style.
    
    * Optionally return the sub-schema for commands and events given as
      arguments.
    
      Right now qmp_query_schema() sends the string literal computed by
      qmp-introspect.py.  To compute sub-schema at run time, we'd have to
      duplicate parts of qapi-introspect.py in C.  Unattractive.
    
    * Let clients cache the output of query-qmp-schema.
    
      It changes only on QEMU upgrades, i.e. rarely.  Provide a command
      query-qmp-schema-hash.  Clients can have a cache indexed by hash,
      and re-query the schema only when they don't have it cached.  Even
      simpler: put the hash in the QMP greeting.
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    39a18158