Commit 1e37d059 authored by Stefan Weil's avatar Stefan Weil Committed by Anthony Liguori
Browse files

raw-posix: Handle errors in raw_create



In qemu-iotests, some large images are created using qemu-img.

Without checks for errors, qemu-img will just create an
empty image, and later read / write tests will fail.

With the patch, failures during image creation are detected
and reported.
Signed-off-by: default avatarStefan Weil <weil@mail.berlios.de>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent 09ac35ac
......@@ -852,6 +852,7 @@ again:
static int raw_create(const char *filename, QEMUOptionParameter *options)
{
int fd;
int result = 0;
int64_t total_size = 0;
/* Read out options */
......@@ -864,11 +865,17 @@ static int raw_create(const char *filename, QEMUOptionParameter *options)
fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
if (fd < 0)
return -EIO;
ftruncate(fd, total_size * 512);
close(fd);
return 0;
if (fd < 0) {
result = -errno;
} else {
if (ftruncate(fd, total_size * 512) != 0) {
result = -errno;
}
if (close(fd) != 0) {
result = -errno;
}
}
return result;
}
static void raw_flush(BlockDriverState *bs)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment