1. 11 Mar, 2013 14 commits
  2. 12 Feb, 2013 1 commit
  3. 11 Feb, 2013 1 commit
    • Stefan Hajnoczi's avatar
      migration: restrict scope of incoming fd read handler · d7cd3694
      Stefan Hajnoczi authored
      
      
      The incoming migration is processed in a coroutine and uses an fd read
      handler to enter the yielded coroutine when data becomes available.
      
      The read handler was set too broadly, so that spurious coroutine entries
      were be triggered if other coroutine users yielded (like the block
      layer's bdrv_write() function).
      
      Install the fd read only only when yielding for more data to become
      available.  This prevents spurious coroutine entries which break code
      that assumes only a specific set of places can re-enter the coroutine.
      
      This patch fixes crashes in block/raw-posix.c that are triggered with
      "migrate -b" when qiov becomes a dangling pointer due to a spurious
      coroutine entry that frees qiov early.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Message-id: 1360598505-5512-1-git-send-email-stefanha@redhat.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      d7cd3694
  4. 01 Feb, 2013 2 commits
  5. 17 Jan, 2013 3 commits
  6. 11 Jan, 2013 1 commit
  7. 02 Jan, 2013 1 commit
    • Michael Tokarev's avatar
      savevm.c: cleanup system includes · 74e91370
      Michael Tokarev authored
      
      
      savevm.c suffers from the same problem as some other files.
      Some years ago savevm.c was created from vl.c, moving some
      code from there into a separate file.  At that time, all
      includes were just copied from vl.c to savevm.c, without
      checking which ones are needed and which are not.
      
      But actually most of that stuff is _not_ needed.  More, some
      stuff is wrong, for example, *BSD #ifdef'ery around <util.h>
      vs <libutil.h> - for one, it fails to build on Debian/kFreebsd.
      
      Just remove all this.  Maybe there's a possibility to clean
      it up further - like removing <windows.h> (and maybe including
      winsock.h for htons etc), and maybe it's possible to remove
      some internal #includes too, but I didn't check this.
      
      While at it, remove duplicate #include of qemu/timer.h.
      Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      74e91370
  8. 20 Dec, 2012 2 commits
    • Juan Quintela's avatar
      savevm: New save live migration method: pending · e4ed1541
      Juan Quintela authored
      
      
      Code just now does (simplified for clarity)
      
          if (qemu_savevm_state_iterate(s->file) == 1) {
             vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
             qemu_savevm_state_complete(s->file);
          }
      
      Problem here is that qemu_savevm_state_iterate() returns 1 when it
      knows that remaining memory to sent takes less than max downtime.
      
      But this means that we could end spending 2x max_downtime, one
      downtime in qemu_savevm_iterate, and the other in
      qemu_savevm_state_complete.
      
      Changed code to:
      
          pending_size = qemu_savevm_state_pending(s->file, max_size);
          DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
          if (pending_size >= max_size) {
              ret = qemu_savevm_state_iterate(s->file);
           } else {
              vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
              qemu_savevm_state_complete(s->file);
           }
      
      So what we do is: at current network speed, we calculate the maximum
      number of bytes we can sent: max_size.
      
      Then we ask every save_live section how much they have pending.  If
      they are less than max_size, we move to complete phase, otherwise we
      do an iterate one.
      
      This makes things much simpler, because now individual sections don't
      have to caluclate the bandwidth (it was implossible to do right from
      there).
      Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      e4ed1541
    • Juan Quintela's avatar
      migration: make writes blocking · dd217b87
      Juan Quintela authored
      
      
      Move all the writes to the migration_thread, and make writings
      blocking.  Notice that are still using the iothread for everything
      that we do.
      Signed-off-by: default avatarJuan Quintela <quintela@redhat.com>
      dd217b87
  9. 19 Dec, 2012 7 commits
  10. 02 Nov, 2012 6 commits
  11. 30 Oct, 2012 1 commit
  12. 17 Oct, 2012 1 commit