1. 11 Mar, 2013 22 commits
  2. 22 Feb, 2013 4 commits
  3. 11 Feb, 2013 2 commits
    • Stefan Hajnoczi's avatar
      migration: restrict scope of incoming fd read handler · d7cd3694
      Stefan Hajnoczi authored
      
      
      The incoming migration is processed in a coroutine and uses an fd read
      handler to enter the yielded coroutine when data becomes available.
      
      The read handler was set too broadly, so that spurious coroutine entries
      were be triggered if other coroutine users yielded (like the block
      layer's bdrv_write() function).
      
      Install the fd read only only when yielding for more data to become
      available.  This prevents spurious coroutine entries which break code
      that assumes only a specific set of places can re-enter the coroutine.
      
      This patch fixes crashes in block/raw-posix.c that are triggered with
      "migrate -b" when qiov becomes a dangling pointer due to a spurious
      coroutine entry that frees qiov early.
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Message-id: 1360598505-5512-1-git-send-email-stefanha@redhat.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      d7cd3694
    • Markus Armbruster's avatar
      error: Strip trailing '\n' from error string arguments (again) · 312fd5f2
      Markus Armbruster authored
      Commit 6daf194d and be62a2eb
      
       got rid of a bunch, but they keep coming
      back.  Tracked down with this Coccinelle semantic patch:
      
          @r@
      	expression err, eno, cls, fmt;
      	position p;
          @@
          (
      	error_report(fmt, ...)@p
          |
      	error_set(err, cls, fmt, ...)@p
          |
      	error_set_errno(err, eno, cls, fmt, ...)@p
          |
      	error_setg(err, fmt, ...)@p
          |
      	error_setg_errno(err, eno, fmt, ...)@p
          )
          @script:python@
      	fmt << r.fmt;
      	p << r.p;
          @@
          if "\\n" in str(fmt):
      	print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Message-id: 1360354939-10994-4-git-send-email-armbru@redhat.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      312fd5f2
  4. 17 Jan, 2013 10 commits
  5. 20 Dec, 2012 2 commits