- 11 Mar, 2013 1 commit
-
-
Blue Swirl authored
96c63847 did not adjust Win32 #ifdeffery properly, breaking build in later commits. Fix. Signed-off-by:
Blue Swirl <blauwirbel@gmail.com> Tested-by:
-
- 08 Mar, 2013 16 commits
-
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
qemu-char is now independent of the QEMU main loop. Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Amit Shah authored
Signed-off-by:
-
Anthony Liguori authored
This lets ptys support adding front end watchs. Signed-off-by:
-
Anthony Liguori authored
This allows a front-end to request for a callback when the backend is writable again. Signed-off-by:
-
Anthony Liguori authored
I didn't bother switching to g_io_channel_read/write because we need to use sendmsg on Unix. No problem though since we're using an unbuffered channel. Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
Signed-off-by:
-
Anthony Liguori authored
This uses the newly introduced IOWatchPoll source. Signed-off-by:
-
Anthony Liguori authored
This is a special GSource that supports CharDriverState style poll callbacks. For reviewability and bisectability, this code is #if 0'd out in this patch to avoid unused warnings since all of the functions are static. Signed-off-by:
-
Anthony Liguori authored
This code is very old dating back to 2007. What is puzzling is that STDIO_MAX_CLIENTS was always #define to 1 meaning that all of the code to deal with more than one client was unreachable. Just remove the whole mess of it. Signed-off-by:
-
- 04 Mar, 2013 1 commit
-
-
MORITA Kazutaka authored
Signed-off-by:
-
- 21 Feb, 2013 1 commit
-
-
Anthony Liguori authored
We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. Signed-off-by:
-
- 13 Feb, 2013 1 commit
-
-
Markus Armbruster authored
Simplifies the schema and the code. QMP command { "execute" : "chardev-add", "arguments" : { "id" : "ser0", "backend" : { "type" : "port", "data" : { "type": "serial", "device":"/dev/ttyS0"} } } } becomes { "execute" : "chardev-add", "arguments" : { "id" : "ser0", "backend" : { "type" : "serial", "data" : { "device":"/dev/ttyS0"} } } } Bonus: nicer error messages. "unknown chardev port (1)" becomes "character device backend type 'parallel' not supported". Signed-off-by:
-
- 11 Feb, 2013 1 commit
-
-
Markus Armbruster authored
Commit 6daf194d and be62a2eb got rid of a bunch, but they keep coming back. Tracked down with this Coccinelle semantic patch: @r@ expression err, eno, cls, fmt; position p; @@ ( error_report(fmt, ...)@p | error_set(err, cls, fmt, ...)@p | error_set_errno(err, eno, cls, fmt, ...)@p | error_setg(err, fmt, ...)@p | error_setg_errno(err, eno, fmt, ...)@p ) @script:python@ fmt << r.fmt; p << r.p; @@ if "\\n" in str(fmt): print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt) Signed-off-by:
-
- 06 Feb, 2013 12 commits
-
-
Markus Armbruster authored
Signed-off-by:
-
Markus Armbruster authored
New device, has never been released, so we can still improve things without worrying about compatibility. Naming is a mess. The code calls the device driver CirMemCharDriver, the public API calls it "memory", "memchardev", or "memchar", and the special commands are named like "memchar-FOO". "memory" is a particularly unfortunate choice, because there's another character device driver called MemoryDriver. Moreover, the device's distinctive property is that it's a ring buffer, not that's in memory. Therefore: * Rename CirMemCharDriver to RingBufCharDriver, and call the thing a "ringbuf" in the API. * Rename QMP and HMP commands from memchar-FOO to ringbuf-FOO. * Rename device parameter from maxcapacity to size (simple words are good for you). * Clearly mark the parameter as optional in documentation. * Fix error reporting so that chardev-add reports to current monitor, not stderr. * Replace cirmem in C identifiers by ringbuf. * Rework documentation. Document the impact of our crappy UTF-8 handling on reading. * QMP examples that even work. I could split this up into multiple commits, but they'd change the same documentation lines multiple times. Not worth it. Signed-off-by:
-
Markus Armbruster authored
Inline trivial cirmem_chr_is_empty() into its only caller. Rename qemu_chr_cirmem_count() to cirmem_count(). Fast ring buffer index wraparound. Without this, there's no point in restricting size to a power two. qemu_is_chr(chr, "memory") returns *zero* when chr is a memory character device, which isn't what I'd expect. Replace it by the saner and more obviously correct chr_is_cirmem(). Also avoids encouraging testing for specific character devices elsewhere. Signed-off-by:
-
Markus Armbruster authored
This is a new device, so there's no compatibility to maintain, and its use case isn't common enough to justify shorthand syntax. Signed-off-by:
-
Markus Armbruster authored
Undocumented misfeature, get rid of it while we can. Signed-off-by:
-
Markus Armbruster authored
Signed-off-by:
-
Markus Armbruster authored
Signed-off-by:
-
Markus Armbruster authored
Signed-off-by:
-
Markus Armbruster authored
Const-correctness, consistently use standard C types instead of mixing them with GLib types. Signed-off-by:
-
Markus Armbruster authored
New errors should be generic unless there's a real use case for rich errors. Signed-off-by:
-
Markus Armbruster authored
The data returned has a well-defined size, which makes the size returned along with it redundant at best. Drop it. Signed-off-by:
-
Markus Armbruster authored
Command memchar-write takes data and size parameter. Begs the question what happens when data doesn't match size. With format base64, qmp_memchar_write() copies the full data argument, regardless of size argument. With format utf8, qmp_memchar_write() copies size bytes from data, happily reading beyond data. Copies crap from the heap or even crashes. Drop the size parameter, and always copy the full data argument. Signed-off-by:
-
- 26 Jan, 2013 1 commit
-
-
Peter Maydell authored
Avoid unused variable warnings: qemu-char.c: In function 'qmp_chardev_open_port': qemu-char.c:3132: warning: unused variable 'fd' qemu-char.c:3132: warning: unused variable 'flags' in configurations with neither HAVE_CHARDEV_TTY nor HAVE_CHARDEV_PARPORT set. Signed-off-by:
-
- 25 Jan, 2013 3 commits
-
-
Lei Li authored
Signed-off-by:
-
Lei Li authored
Signed-off-by:
-
Lei Li authored
Signed-off-by:
-
- 16 Jan, 2013 3 commits
-
-
Gerd Hoffmann authored
The ptsname is returned directly, so there is no need to use query-chardev to figure the pty device path. Signed-off-by: -
Gerd Hoffmann authored
qemu_chr_open_socket is split into two functions. All initialization after creating the socket file handler is split away into the new qemu_chr_open_socket_fd function. chr->filename doesn't get filled from QemuOpts any more. Qemu gathers the information using getsockname and getnameinfo instead. This way it will also work correctly for file handles passed via file descriptor passing. Finally qmp_chardev_open_socket() is the actual qmp hotplug implementation which basically just calls socket_listen or socket_connect and the new qemu_chr_open_socket_fd function. Signed-off-by: -
Gerd Hoffmann authored
Also alias the old parport name to parallel for -chardev. Signed-off-by:
-