Skip to content
GitLab
Switch branch/tag
  1. 16 Jan, 2013 1 commit
  3. 15 Jan, 2013 2 commits
  5. 19 Dec, 2012 8 commits
  7. 17 Dec, 2012 2 commits
  9. 26 Nov, 2012 1 commit
    • Alexey Kardashevskiy's avatar
      kvm: fix incorrect length in a loop over kvm dirty pages map · 752ced04
      Alexey Kardashevskiy authored 
      

QEMU allocates a map enough for 4k pages. However the system page size
can be 64K (for example on POWER) and the host kernel uses only a small
part of it as one big stores a dirty flag for 16 pages 4K each,
the hpratio variable stores this ratio and
the kvm_get_dirty_pages_log_range function handles it correctly.

However kvm_get_dirty_pages_log_range still goes beyond the data
provided by the host kernel which is not correct. It does not cause
errors at the moment as the whole bitmap is zeroed before doing KVM ioctl.

The patch reduces number of iterations over the map.
Signed-off-by: default avatarAlexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: default avatarAlexander Graf <agraf@suse.de>
      752ced04
  11. 14 Nov, 2012 1 commit
  13. 31 Oct, 2012 3 commits
  15. 23 Oct, 2012 1 commit
    • Avi Kivity's avatar
      Rename target_phys_addr_t to hwaddr · a8170e5e
      Avi Kivity authored 
      

target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
reserved) and its purpose doesn't match the name (most target_phys_addr_t
addresses are not target specific).  Replace it with a finger-friendly,
standards conformant hwaddr.

Outstanding patchsets can be fixed up with the command

  git rebase -i --exec 'find -name "*.[ch]"
                        | xargs s/target_phys_addr_t/hwaddr/g' origin
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      a8170e5e
  17. 22 Oct, 2012 2 commits
  19. 15 Oct, 2012 2 commits
  21. 14 Sep, 2012 1 commit
  23. 11 Sep, 2012 3 commits
  25. 10 Sep, 2012 2 commits
  27. 09 Sep, 2012 2 commits
    • Jan Kiszka's avatar
      kvm: Clean up irqfd API · b131c74a
      Jan Kiszka authored 
      

No need to expose the fd-based interface, everyone will already be fine
with the more handy EventNotifier variant. Rename the latter to clarify
that we are still talking about irqfds here.
Signed-off-by: default avatarJan Kiszka <jan.kiszka@siemens.com>
Acked-by: default avatarAlex Williamson <alex.williamson@redhat.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
      b131c74a
    • Christian Borntraeger's avatar
      qemu: Use valgrind annotations to mark kvm guest memory as defined · 62fe8331
      Christian Borntraeger authored 
      

valgrind with kvm produces a big amount of false positives regarding
"Conditional jump or move depends on uninitialised value(s)". This
happens because the guest memory is allocated with qemu_vmalloc which
boils down posix_memalign etc. This function is (correctly) considered
by valgrind as returning undefined memory.

Since valgrind is based on jitting code, it will not be able to see
changes made by the guest to guest memory if this is done by KVM_RUN,
thus keeping most of the guest memory undefined.

Now lots of places in qemu will then use guest memory to change behaviour.
To avoid the flood of these messages, lets declare the whole guest
memory as defined. This will reduce the noise and allows us to see real
problems.

In the future we might want to make this conditional, since there
is actually something that we can use those false positives for:
These messages will point to code that depends on guest memory, so
we can use these backtraces to actually make an audit that is focussed
only at those code places. For normal development we dont want to
see those messages, though.
Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
      62fe8331
  29. 09 Aug, 2012 7 commits
  31. 12 Jul, 2012 2 commits