Skip to content
  • Max Reitz's avatar
    block/drive-mirror: Reuse backing HD for sync=none · 117e0c82
    Max Reitz authored
    For "none" sync mode in "absolute-paths" mode, the current image should
    be used as the backing file for the newly created image.
    
    The current behavior is:
    a) If the image to be mirrored has a backing file, use that (which is
       wrong, since the operations recorded by "none" are applied to the
       image itself, not to its backing file).
    b) If the image to be mirrored lacks a backing file, the target doesn't
       have one either (which is not really wrong, but not really right,
       either; "none" records a set of operations executed on the image
       file, therefore having no backing file to apply these operations on
       seems rather pointless).
    
    For a, this is clearly a bugfix. For b, it is still a bugfix, although
    it might break existing API - but since that case crashed qemu just
    three weeks ago (before 14526864
    
    ), we
    can safely assume there is no such API relying on that case yet.
    
    Suggested-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Message-id: 1385407736-13941-2-git-send-email-mreitz@redhat.com
    Signed-off-by: default avatarAnthony Liguori <aliguori@amazon.com>
    117e0c82