• Jason Wang's avatar
    tap: fix NULL dereference when passing invalid parameters to tap · c87826a8
    Jason Wang authored
    This patch forbid the following invalid parameters to tap:
    
    1) fd and vhostfds were specified but vhostfd were not specified
    2) vhostfds were specified but fds were not specified
    3) fds and vhostfd were specified
    
    For 1 and 2, net_init_tap_one() will still pass NULL as vhostfdname to
    monitor_handle_fd_param(), which may crash the qemu.
    
    Also remove the unnecessary has_fd check.
    
    Cc: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Stefan Hajnoczi <shajnocz@redhat.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: qemu-stable@nongnu.org
    Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    c87826a8
tap.c 23.1 KB