Skip to content
  • Fam Zheng's avatar
    block: Print its file name if backing file opening failed · b04b6b6e
    Fam Zheng authored
    
    
    If backing file doesn't exist, the error message is confusing and
    misleading:
    
        $ qemu /tmp/a.qcow2
        qemu: could not open disk image /tmp/a.qcow2: Could not open file: No
        such file or directory
    
    But...
    
        $ ls /tmp/a.qcow2
        /tmp/a.qcow2
    
        $ qemu-img info /tmp/a.qcow2
        image: /tmp/a.qcow2
        file format: qcow2
        virtual size: 8.0G (8589934592 bytes)
        disk size: 196K
        cluster_size: 65536
        backing file: /tmp/b.qcow2
    
    Because...
    
        $ ls /tmp/b.qcow2
        ls: cannot access /tmp/b.qcow2: No such file or directory
    
    This is not intuitive. It's better to have the missing file's name in
    the error message. With this patch:
    
        $ qemu-io -c 'read 0 512' /tmp/a.qcow2
        qemu-io: can't open device /tmp/a.qcow2: Could not open backing
        file: Could not open '/stor/vm/arch.raw': No such file or directory
        no file open, try 'help open'
    
    Which is a little bit better.
    
    Signed-off-by: default avatarFam Zheng <famz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    b04b6b6e