Skip to content
  • Vladimir Sementsov-Ogievskiy's avatar
    dirty-bitmaps: clean-up bitmaps loading and migration logic · 9c98f145
    Vladimir Sementsov-Ogievskiy authored
    
    
    This patch aims to bring the following behavior:
    
    1. We don't load bitmaps, when started in inactive mode. It's the case
    of incoming migration. In this case we wait for bitmaps migration
    through migration channel (if 'dirty-bitmaps' capability is enabled) or
    for invalidation (to load bitmaps from the image).
    
    2. We don't remove persistent bitmaps on inactivation. Instead, we only
    remove bitmaps after storing. This is the only way to restore bitmaps,
    if we decided to resume source after [failed] migration with
    'dirty-bitmaps' capability enabled (which means, that bitmaps were not
    stored).
    
    3. We load bitmaps on open and any invalidation, it's ok for all cases:
      - normal open
      - migration target invalidation with dirty-bitmaps capability
        (bitmaps are migrating through migration channel, the are not
         stored, so they should have IN_USE flag set and will be skipped
         when loading. However, it would fail if bitmaps are read-only[1])
      - migration target invalidation without dirty-bitmaps capability
        (normal load of the bitmaps, if migrated with shared storage)
      - source invalidation with dirty-bitmaps capability
        (skip because IN_USE)
      - source invalidation without dirty-bitmaps capability
        (bitmaps were dropped, reload them)
    
    [1]: to accurately handle this, migration of read-only bitmaps is
         explicitly forbidden in this patch.
    
    New mechanism for not storing bitmaps when migrate with dirty-bitmaps
    capability is introduced: migration filed in BdrvDirtyBitmap.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    9c98f145