Commit 2b9aef6f authored by Su Hang's avatar Su Hang Committed by Paolo Bonzini

checkpatch: add check for `while` and `for`

Adding check for `while` and `for` statements, which condition has more than
one line.

The former checkpatch.pl can check `if` statement, which condition has more
than one line, whether block misses brace round, like this:
'''
if (cond1 ||
    cond2)
    statement;
'''
But it doesn't do the same check for `for` and `while` statements.

Using `(?:...)` instead of `(...)` in regex pattern catch.
Because `(?:...)` is faster and avoids unwanted side-effect.
Suggested-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
Suggested-by: default avatarEric Blake <eblake@redhat.com>
Suggested-by: default avatarThomas Huth <thuth@redhat.com>
Signed-off-by: default avatarSu Hang <suhang16@mails.ucas.ac.cn>
Message-Id: <1520319890-19761-1-git-send-email-suhang16@mails.ucas.ac.cn>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent fb8446d9
...@@ -2352,8 +2352,9 @@ sub process { ...@@ -2352,8 +2352,9 @@ sub process {
} }
} }
# check for missing bracing round if etc # check for missing bracing around if etc
if ($line =~ /(^.*)\bif\b/ && $line !~ /\#\s*if/) { if ($line =~ /(^.*)\b(?:if|while|for)\b/ &&
$line !~ /\#\s*if/) {
my ($level, $endln, @chunks) = my ($level, $endln, @chunks) =
ctx_statement_full($linenr, $realcnt, 1); ctx_statement_full($linenr, $realcnt, 1);
if ($dbg_adv_apw) { if ($dbg_adv_apw) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment