Commit 5e43efb2 authored by Paolo Bonzini's avatar Paolo Bonzini

checkpatch: do not recommend qemu_strtok over strtok

If anything it should recommend strtok_r!
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent fe854538
......@@ -2463,8 +2463,8 @@ sub process {
WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
}
# recommend qemu_strto* over strto*
if ($line =~ /\b(strto.*?)\s*\(/) {
# recommend qemu_strto* over strto* for numeric conversions
if ($line =~ /\b(strto[^k].*?)\s*\(/) {
WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
}
# check for module_init(), use category-specific init macros explicitly please
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment