Commit f8dccbb6 authored by Stefan Hajnoczi's avatar Stefan Hajnoczi

checkpatch: consider git extended headers valid patches

Renames look like this with git-diff(1) when diff.renames = true is set:

  diff --git a/a b/b
  similarity index 100%
  rename from a
  rename to b

This raises the "Does not appear to be a unified-diff format patch"
error because only considers a diff valid if it contains
at least one "@@" hunk.

This patch accepts renames and copies too so that exits
successfully when a diff only renames/copies files.  The git diff
extended header format is described on the git-diff(1) man page.
Reported-by: default avatarColin Lord <>
Signed-off-by: default avatarStefan Hajnoczi <>
Reviewed-by: default avatarEric Blake <>
Signed-off-by: default avatarStefan Hajnoczi <>
parent 7e003465
......@@ -1279,6 +1279,11 @@ sub process {
# Accept git diff extended headers as valid patches
if ($line =~ /^(?:rename|copy) (?:from|to) [\w\/\.\-]+\s*$/) {
$is_patch = 1;
#check the patch for a signoff:
if ($line =~ /^\s*signed-off-by:/i) {
# This is a signoff, if ugly, so do not double report.
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment