1. 04 Feb, 2014 3 commits
  2. 13 Jan, 2014 3 commits
  3. 06 Jan, 2014 1 commit
    • Luiz Capitulino's avatar
      migration: qmp_migrate(): keep working after syntax error · c9501142
      Luiz Capitulino authored
      If a user or QMP client enter a bad syntax for the migrate
      command in QMP/HMP, then the migrate command will never succeed
      from that point on.
      For example, if you enter:
      (qemu) migrate tcp;0:4444
      migrate: Parameter 'uri' expects a valid migration protocol
      Then the migrate command will always fail from now on:
      (qemu) migrate tcp:0:4444
      migrate: There's a migration process in progress
      The problem is that qmp_migrate() sets the migration status to
      MIG_STATE_SETUP and doesn't reset it on syntax error. This bug
      was introduced by commit 29ae8a41.
      Reviewed-by: default avatarMichael R. Hines <mrhines@us.ibm.com>
      Signed-off-by: default avatarLuiz Capitulino <lcapitulino@redhat.com>
  4. 05 Oct, 2013 1 commit
  5. 24 Sep, 2013 1 commit
  6. 22 Aug, 2013 2 commits
  7. 01 Aug, 2013 2 commits
  8. 29 Jul, 2013 2 commits
    • Stefan Hajnoczi's avatar
      migration: fix spice migration · 02edd2e7
      Stefan Hajnoczi authored
      Commit 29ae8a41 ("rdma: introduce
      MIG_STATE_NONE and change MIG_STATE_SETUP state transition") changed the
      state transitions during migration setup.
      Spice used to be notified with MIG_STATE_ACTIVE and it detected this
      using migration_is_active().  Spice is now notified with
      MIG_STATE_SETUP and migration_is_active() no longer works.
      Replace migration_is_active() with migration_in_setup() to fix spice
      Cc: Michael R. Hines <mrhines@us.ibm.com>
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    • Stefan Hajnoczi's avatar
      migration: notify migration state before starting thread · 9287ac27
      Stefan Hajnoczi authored
      The migration thread runs outside the QEMU global mutex when possible.
      Therefore we must notify migration state change *before* starting the
      migration thread.
      This allows registered listeners to act before live migration iterations
      begin.  Therefore they can get into a state that allows for live
      migration.  When the migration thread starts everything will be ready.
      Without this patch there is a race condition during migration setup,
      depending on whether the migration thread has already transitioned from
      SETUP to ACTIVE state.
      Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
  9. 23 Jul, 2013 4 commits
  10. 19 Jul, 2013 1 commit
  11. 15 Jul, 2013 1 commit
    • Kevin Wolf's avatar
      migration: Fail migration on bdrv_flush_all() error · 0e1146a7
      Kevin Wolf authored
      If bdrv_flush_all() returns an error, there is an inconsistency in the
      view of an image file between the source and the destination host.
      Completing the migration would lead to corruption. Better abort
      migration in this case.
      To reproduce this case, try the following (ensures that there is
      something to flush, and then fails that flush):
      $ qemu-img create -f qcow2 test.qcow2 1G
      $ cat blkdebug.cfg
      event = "flush_to_os"
      errno = "5"
      $ qemu-system-x86_64 -hda blkdebug:blkdebug.cfg:test.qcow2 -monitor stdio
      (qemu) qemu-io ide0-hd0 "write 0 4k"
      (qemu) migrate ...
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
  12. 12 Jul, 2013 1 commit
  13. 04 Jul, 2013 1 commit
  14. 27 Jun, 2013 2 commits
  15. 01 Jun, 2013 1 commit
  16. 17 May, 2013 1 commit
    • Michael Roth's avatar
      Revert "migration: don't account sleep time for calculating bandwidth" · 77417f10
      Michael Roth authored
      This reverts commit 7161082c.
      Reverting this patch fixes a divide-by-zero error in qemu that can be
      fairly reliably triggered by doing block migration. In this case, the
      configuration/error was:
      source: temp/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -L temp-bios
      -M pc-i440fx-1.4 -m 512M -kernel boot/vmlinuz-x86_64 -initrd
      boot/test-initramfs-x86_64.img.gz -vga std -append seed=1234 -drive
      file=disk1.img,if=virtio -drive file=disk2.img,if=virtio -device
      virtio-net-pci,netdev=net0 -netdev user,id=net0 -monitor
      unix:/tmp/vm-hmp.sock,server,nowait -qmp
      unix:/tmp/vm-qmp.sock,server,nowait -vnc :100
      16837 Floating point exception(core dumped)
      target: temp/x86_64-softmmu/qemu-system-x86_64 -enable-kvm -L temp-bios
      -M pc-i440fx-1.4 -m 512M -kernel boot/vmlinuz-x86_64 -initrd
      boot/test-initramfs-x86_64.img.gz -vga std -append seed=1234 -drive
      file=target_disk1.img,if=virtio -drive file=target_disk2.img,if=virtio
      -device virtio-net-pci,netdev=net0 -netdev user,id=net0 -incoming
      unix:/tmp/migrate.sock -monitor
      unix:/tmp/vm-hmp-incoming.sock,server,nowait -qmp
      unix:/tmp/vm-qmp-incoming.sock,server,nowait -vnc :101
      Receiving block device images
      20 %
      21 %
      load of migration failed
      This revert potentially re-introduces a bug that was present in 1.4,
      but fixes a prevalent issue with block migration so we should revert
      it for now and take an updated patch later.
      * fixed up to remove logic introduced in 7161082c while leaving
        changes in HEAD intact
      Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
      Message-id: 1368739544-31021-1-git-send-email-mdroth@linux.vnet.ibm.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
  17. 17 Apr, 2013 1 commit
  18. 02 Apr, 2013 1 commit
  19. 26 Mar, 2013 1 commit
  20. 11 Mar, 2013 10 commits