1. 24 Jan, 2014 5 commits
  2. 22 Jan, 2014 1 commit
  3. 06 Jan, 2014 1 commit
  4. 20 Dec, 2013 1 commit
  5. 16 Dec, 2013 1 commit
  6. 27 Nov, 2013 1 commit
    • Max Reitz's avatar
      block/drive-mirror: Reuse backing HD for sync=none · 117e0c82
      Max Reitz authored
      For "none" sync mode in "absolute-paths" mode, the current image should
      be used as the backing file for the newly created image.
      
      The current behavior is:
      a) If the image to be mirrored has a backing file, use that (which is
         wrong, since the operations recorded by "none" are applied to the
         image itself, not to its backing file).
      b) If the image to be mirrored lacks a backing file, the target doesn't
         have one either (which is not really wrong, but not really right,
         either; "none" records a set of operations executed on the image
         file, therefore having no backing file to apply these operations on
         seems rather pointless).
      
      For a, this is clearly a bugfix. For b, it is still a bugfix, although
      it might break existing API - but since that case crashed qemu just
      three weeks ago (before 14526864), we
      can safely assume there is no such API relying on that case yet.
      Suggested-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Message-id: 1385407736-13941-2-git-send-email-mreitz@redhat.com
      Signed-off-by: default avatarAnthony Liguori <aliguori@amazon.com>
      117e0c82
  7. 14 Nov, 2013 2 commits
    • Amos Kong's avatar
      qmp: access the local QemuOptsLists for drive option · 968854c8
      Amos Kong authored
      Currently we have three QemuOptsList (qemu_common_drive_opts,
      qemu_legacy_drive_opts, and qemu_drive_opts), only qemu_drive_opts
      is added to vm_config_groups[].
      
      This patch changes query-command-line-options to access three local
      QemuOptsLists for drive option, and merge the description items
      together.
      Signed-off-by: default avatarAmos Kong <akong@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      968854c8
    • Max Reitz's avatar
      block/drive-mirror: Check for NULL backing_hd · 14526864
      Max Reitz authored
      It should be possible to execute the QMP "drive-mirror" command in
      "none" sync mode and "absolute-paths" mode even for block devices
      lacking a backing file.
      
      "absolute-paths" does in fact not require a backing file to be present,
      as can be seen from the "top" sync mode code path. "top" basically
      states that the device should indeed have a backing file - however, the
      current code catches the case if it doesn't and then simply treats it as
      "full" sync mode, creating a target image without a backing file (in
      "absolute-paths" mode). Thus, "absolute-paths" does not imply the target
      file must indeed have a backing file.
      
      Therefore, the target file may be left unbacked in case of "none" sync
      mode as well, if the specified device is not backed either. Currently,
      qemu will crash trying to dereference the backing file pointer since it
      assumes that it will always be non-NULL in that case ("none" with
      "absolute-paths").
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      Reviewed-by: default avatarWenchao Xia <xiawenc@linux.vnet.ibm.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      14526864
  8. 07 Nov, 2013 1 commit
  9. 17 Oct, 2013 1 commit
  10. 11 Oct, 2013 16 commits
  11. 02 Oct, 2013 1 commit
  12. 20 Sep, 2013 1 commit
  13. 12 Sep, 2013 5 commits
  14. 06 Sep, 2013 3 commits