1. 27 Nov, 2018 1 commit
  2. 19 Nov, 2018 1 commit
  3. 15 Nov, 2018 1 commit
  4. 12 Nov, 2018 1 commit
  5. 06 Nov, 2018 1 commit
  6. 31 Oct, 2018 9 commits
  7. 26 Oct, 2018 4 commits
  8. 19 Oct, 2018 2 commits
  9. 16 Oct, 2018 4 commits
  10. 04 Oct, 2018 2 commits
  11. 01 Oct, 2018 1 commit
  12. 28 Aug, 2018 5 commits
    • Eric Blake's avatar
      qapi: Add comments to aid debugging generated introspection · 8c643361
      Eric Blake authored
      We consciously chose in commit 1a9a507b to hide QAPI type names
      from the introspection output on the wire, but added a command
      line option -u to unmask the type name when doing a debug build.
      The unmask option still remains useful to some other forms of
      automated analysis, so it will not be removed; however, when it
      is not in use, the generated .c file can be hard to read.  At
      the time when we first introduced masking, the generated file
      consisted only of a monolithic C string, so there was no clean
      way to inject any comments.
      Later, in commit 7d0f982b, we switched the generation to output
      a QLit object, in part to make it easier for future addition of
      conditional compilation.  In fact, commit d626b6c1 took advantage
      of this by passing a tuple instead of a bare object for encoding
      the output of conditionals.  By extending that tuple, we can now
      interject strategic comments.
      For now, type name debug aid comments are only output once per
      meta-type, rather than at all uses of the number used to encode
      the type within the introspection data.  But this is still a lot
      more convenient than having to regenerate the file with the
      unmask operation temporarily turned on - merely search the
      generated file for '"NNN" =' to learn the corresponding source
      name and associated definition of type NNN.
      The generated qapi-introspect.c changes only with the addition
      of comments, such as:
      | @@ -14755,6 +15240,7 @@
      |          { "name", QLIT_QSTR("[485]"), },
      |          {}
      |      })),
      | +    /* "485" = QCryptoBlockInfoLUKSSlot */
      |      QLIT_QDICT(((QLitDictEntry[]) {
      |          { "members", QLIT_QLIST(((QLitObject[]) {
      |              QLIT_QDICT(((QLitDictEntry[]) {
      Signed-off-by: default avatarEric Blake <eblake@redhat.com>
      Message-Id: <20180827213943.33524-3-eblake@redhat.com>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      [Rebased, update to qapi-code-gen.txt corrected]
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    • Eric Blake's avatar
      qapi: Minor introspect.py cleanups · 1aa806cc
      Eric Blake authored
      Commit 7d0f982b changed generated introspection output to no longer
      produce long lines in the generated .c file, but failed to adjust
      comments to match.  Add some clarity that the shorter length that
      matters most is the overall QMP response on the wire.
      Commit 25b1ef31 triggers a pep8 formatting nit.
      Signed-off-by: default avatarEric Blake <eblake@redhat.com>
      Message-Id: <20180827213943.33524-2-eblake@redhat.com>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    • Markus Armbruster's avatar
      qapi: Emit a blank line before dummy declaration · 5f1450f5
      Markus Armbruster authored
      We emit a dummy variable in each .c file "to shut up OSX toolchain
      warnings about empty .o files" (commit 252dc310).  Separate it from
      the code preceding it (if any) with a blank line.
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Message-Id: <20180828120736.32323-2-armbru@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    • Peter Xu's avatar
      qapi: Drop qapi_event_send_FOO()'s Error ** argument · 3ab72385
      Peter Xu authored
      The generated qapi_event_send_FOO() take an Error ** argument.  They
      can't actually fail, because all they do with the argument is passing it
      to functions that can't fail: the QObject output visitor, and the
      @qmp_emit callback, which is either monitor_qapi_event_queue() or
      Drop the argument, and pass &error_abort to the QObject output visitor
      and @qmp_emit instead.
      Suggested-by: default avatarEric Blake <eblake@redhat.com>
      Suggested-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
      Message-Id: <20180815133747.25032-4-peterx@redhat.com>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      [Commit message rewritten, update to qapi-code-gen.txt corrected]
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    • Markus Armbruster's avatar
      qapi: Fix build_params() for empty parameter list · bdd2d42b
      Markus Armbruster authored
      build_params() returns '' instead of 'void' when there are no
      parameters.  Can't happen now, but the next commit will change that.
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      [peterx: compose the patch from email replies]
      Signed-off-by: default avatarPeter Xu <peterx@redhat.com>
      Message-Id: <20180815133747.25032-3-peterx@redhat.com>
  13. 23 Aug, 2018 4 commits
  14. 17 Aug, 2018 1 commit
  15. 15 Aug, 2018 2 commits
  16. 23 Jul, 2018 1 commit