Don't leak GError when using CALLS_ERROR
Side question: I can't really see anywhere that the emitted "message" signal from CallsMessageSource is being used. Is that a relic of the past?
Merge request reports
Activity
added 4 commits
-
b7b099d0...eda460ac - 2 commits from branch
Librem5:master
- 486956ee - codestyle: remove whitespaces
- 8730aca9 - plugins: use g_autoptr for GError
-
b7b099d0...eda460ac - 2 commits from branch
- Resolved by Guido Gunther
Side question: I can't really see anywhere that the emitted "message" signal from CallsMessageSource is being used. Is that a relic of the past?
this kind of error reporting is 'interesting' but also looks unused so i'd just remove it.
- Resolved by Evangelos Ribeiro Tzaras
Looks good from visual inspecection and works here. Did this one trip up the flatpak build or is that a different issue?
mentioned in merge request !269 (merged)
added 5 commits
-
9a01b29d...97c2dde0 - 3 commits from branch
Librem5:master
- 3f197149 - codestyle: remove whitespaces
- 7a6b702a - plugins: use g_autoptr for GError
-
9a01b29d...97c2dde0 - 3 commits from branch
Rebased and letting this sit for one more day to have a chance at getting some feedback on !264 (comment 144563)
enabled an automatic merge when the pipeline for 7a6b702a succeeds