Populate Calls Contacts List

cc: @mohammed.sadiq

added 2 commits

• 1795df98 - Contacts: Add folks wrapper from chatty
• 9f5e9bfd - Revert "ui/main-window: Hide contacts pane"

Compare with previous version

@bob.ham where do you want me to add the chatty-* files. @mohammed.sadiq suggested in a separate folder "contrib".

Would it make sense to pull this into a submodule. this would allow chatty and calls to share without being bound to the same version (as in a shared lib).

where do you want me to add the chatty-* files

Not in Calls. If Chatty and Calls are going to share code like this, I would say the code should be in a shared library, as we've discussed before.

Yes, I think we should create a small lib for handling stuff related to contacts.

changed title from WIP: Popolate Calls Contacts List to WIP: Populate Calls Contacts List

added 3 commits

• 7133ba0b - Contacts: Add folks wrapper from chatty
• 8c2ee6af - Revert "ui/main-window: Hide contacts pane"
• c681b128 - Contacts: Add contacts list

Compare with previous version

added 1 commit

• d419544a - Contacts: Add contacts list

Compare with previous version

populating contacts would be great, any plans here?

added 29 commits

• d419544a...a9bd1eba - 26 commits from branch Librem5:master
• ee5a8ff2 - Contacts: Add folks wrapper from chatty
• d1021b4f - Revert "ui/main-window: Hide contacts pane"
• 3e0193bb - Contacts: Add contacts list

Compare with previous version

added 1 commit

• 6c8f72c2 - Move chatty files to contrib

Compare with previous version

added 3 commits

• ec43b924 - Contacts: Add folks wrapper from chatty
• 73bf352e - Revert "ui/main-window: Hide contacts pane"
• 3c320f0a - Contacts: Add contacts list

Compare with previous version

mentioned in issue #177

mentioned in issue OS-issues#179

added 136 commits

• 3c320f0a...ddab47d2 - 133 commits from branch Librem5:master
• 720b0c7b - Contacts: Add folks wrapper from chatty
• 4b3d194f - Revert "ui/main-window: Hide contacts pane"
• 7d93a637 - Contacts: Add contacts list

Compare with previous version

added 8 commits

• 0d814efc - flatpak: use master runtime
• 27cdd6fe - flatpak: add libcanberra
• 4ba301ca - ci: don't use global variables and some cleanup
• c7825f1f - ci: build flatpak in ci
• d97f943c - ci: copy&paste GNOME citemplate
• b019cdd8 - Contacts: Add folks wrapper from chatty
• 76d1467f - Revert "ui/main-window: Hide contacts pane"
• 57e5e075 - Contacts: Add contacts list

Compare with previous version

added 10 commits

• 57e5e075...5bdfb0e2 - 3 commits from branch Librem5:master
• 95b7ef82 - flatpak: use master runtime
• 5179dffe - flatpak: add libcanberra
• d804082d - ci: don't use global variables and some cleanup
• 74ae6a0b - ci: build flatpak in ci
• 264264f7 - ci: copy&paste GNOME citemplate
• 900ae5ef - Revert "ui/main-window: Hide contacts pane"
• c0084b52 - Contacts: Add contacts list

Compare with previous version

added 4 commits

• 8c676130 - ContactsProvider: Add contacts provider
• 3d16f0a1 - Contacts: replace CallsContacts with CallsContactsProvider
• fec3f145 - Revert "ui/main-window: Hide contacts pane"
• 31064e0a - Contacts: Add contacts list

Compare with previous version

added 13 commits

• 31064e0a...9f295a72 - 7 commits from branch Librem5:master
• 3489363e - flatpak: use master runtime
• 9a45241e - flatpak: add libcanberra
• 275b724a - ContactsProvider: Add contacts provider
• 2d02028b - Contacts: replace CallsContacts with CallsContactsProvider
• 27745aa8 - Revert "ui/main-window: Hide contacts pane"
• a69ed883 - Contacts: Add contacts list

Compare with previous version

added 4 commits

• 13ad9c9f - ContactsProvider: Add contacts provider
• 1b6adfc9 - Contacts: replace CallsContacts with CallsContactsProvider
• 825ae836 - Revert "ui/main-window: Hide contacts pane"
• f4f5543c - Contacts: Add contacts list

Compare with previous version

added 4 commits

• 51faa124 - ContactsProvider: Add contacts provider
• dff21e88 - Contacts: replace CallsContacts with CallsContactsProvider
• 89da0028 - Revert "ui/main-window: Hide contacts pane"
• 7917f10c - Contacts: Add contacts list

Compare with previous version

added 4 commits

• 44a8ede0 - ContactsProvider: Add contacts provider
• 6d30a8f3 - Contacts: replace CallsContacts with CallsContactsProvider
• 83502dea - Revert "ui/main-window: Hide contacts pane"
• cf2f52c6 - Contacts: Add contacts list

Compare with previous version

added 4 commits

• 47ec51ba - ContactsProvider: Add contacts provider
• 1c4b45b6 - Contacts: replace CallsContacts with CallsContactsProvider
• 02f70f9e - Revert "ui/main-window: Hide contacts pane"
• 488e1558 - Contacts: Add contacts list

Compare with previous version

unmarked as a Work In Progress

added 8 commits

• 488e1558...f293decd - 2 commits from branch Librem5:master
• 611959d0 - flatpak: use master runtime
• 69bd9ee7 - flatpak: add libcanberra
• 24e9d064 - ContactsProvider: Add contacts provider
• 77497006 - Contacts: replace CallsContacts with CallsContactsProvider
• 647cd626 - Revert "ui/main-window: Hide contacts pane"
• ecad8868 - Contacts: Add contacts list

Compare with previous version

@evangelos.tzaras i think this MR is ready now. It's based on the !238 (closed) MR since else I couldn't use gnome-builder.

added 9 commits

• ecad8868...862e0b5f - 3 commits from branch Librem5:master
• a6013cb8 - flatpak: use master runtime
• 3b647516 - flatpak: add libcanberra
• 77ac6ac5 - ContactsProvider: Add contacts provider
• c4b9a23a - Contacts: replace CallsContacts with CallsContactsProvider
• 83d62324 - Revert "ui/main-window: Hide contacts pane"
• 64022fde - Contacts: Add contacts list

Compare with previous version

added 13 commits

• 64022fde...613d5acd - 7 commits from branch Librem5:master
• 45cf50a3 - flatpak: use master runtime
• e0d49bff - flatpak: add libcanberra
• 69e0f63f - ContactsProvider: Add contacts provider
• aad94c72 - Contacts: replace CallsContacts with CallsContactsProvider
• 21f650a3 - Revert "ui/main-window: Hide contacts pane"
• 5ff830f1 - Contacts: Add contacts list

Compare with previous version

added 8 commits

• 5ff830f1...70c75822 - 4 commits from branch Librem5:master
• 7abf2a34 - ContactsProvider: Add contacts provider
• 913a8188 - Contacts: replace CallsContacts with CallsContactsProvider
• 3b4b6e25 - Revert "ui/main-window: Hide contacts pane"
• 4a426222 - Contacts: Add contacts list

Compare with previous version

added 6 commits

• 611959d0 - flatpak: use master runtime
• 69bd9ee7 - flatpak: add libcanberra
• 55b7a872 - ContactsProvider: Add contacts provider
• ec1e8598 - Contacts: replace CallsContacts with CallsContactsProvider
• d7f057ec - Revert "ui/main-window: Hide contacts pane"
• d4ba7aa1 - Contacts: Add contacts list

Compare with previous version

added 19 commits

• d4ba7aa1...1bfcdd54 - 15 commits from branch Librem5:master
• 52d03f4f - ContactsProvider: Add contacts provider
• b9bb182f - Contacts: replace CallsContacts with CallsContactsProvider
• ae0a8246 - Revert "ui/main-window: Hide contacts pane"
• bb85f81f - Contacts: Add contacts list

Compare with previous version

mentioned in merge request !245 (merged)

Just a few things which are a bit unclear to me, other than that looks nice!

added 5 commits

• 1c8eb87e - 1 commit from branch Librem5:master
• 0b0f96be - ContactsProvider: Add contacts provider
• 309e5154 - Contacts: replace CallsContacts with CallsContactsProvider
• 4fdf9b9c - Revert "ui/main-window: Hide contacts pane"
• aede99de - Contacts: Add contacts list

Compare with previous version

mentioned in issue #88 (closed)

added 8 commits

• aede99de...d6c05e85 - 4 commits from branch Librem5:master
• 4ba9feb2 - ContactsProvider: Add contacts provider
• 0f4f6245 - Contacts: replace CallsContacts with CallsContactsProvider
• 4b3cb668 - Revert "ui/main-window: Hide contacts pane"
• 4020fc9d - Contacts: Add contacts list

Compare with previous version

resolved all threads

added 3 commits

• f61ae1cb - Contacts: replace CallsContacts with CallsContactsProvider
• 4c7b4023 - Revert "ui/main-window: Hide contacts pane"
• 19c9893e - Contacts: Add contacts list

Compare with previous version

enabled an automatic merge when the pipeline for 19c9893e succeeds

merged

Thanks!

mentioned in issue #87 (closed)