Use in-app notification (!96) · Merge requests · Librem5 / calls · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this page for instructions on how to get full permissions. Sorry for the inconvenience.

source.puri.sm migrated to a new server, see new ssh key fingerprint.

This is an archived project. Repository and other project resources are read-only.

Merged Julian Sparber requested to merge julian.sparber/calls:use_in_app_notification into master 5 years ago

All threads resolved!

Use in-app notifications specified in GNOMEs HIG. This creates a new class for in-app notifications which can be used in different places. It also replaces the GtkInfoBar with the in-app notification.

For reference https://developer.gnome.org/hig/stable/in-app-notifications.html.en

Fixes: #132 (closed), #11 (closed)

Edited 5 years ago by Julian Sparber

Approval is optional

Activity

Julian Sparber added 5 commits 5 years ago
added 5 commits

b32dff73...a91da3f8 - 2 commits from branch Librem5:master

662f7f0b - Add class for in-app notification

584afc22 - MainWindow: use in-app notification for messages

dc5be2b6 - CallWindow: use in-app notification

Compare with previous version
Toggle commit list
Julian Sparber added 3 commits 5 years ago
added 3 commits

c14fe0f6 - Add class for in-app notification

6916a425 - MainWindow: use in-app notification for messages

48d0e641 - CallWindow: use in-app notification

Compare with previous version
Julian Sparber mentioned in merge request !98 5 years ago

mentioned in merge request !98
Julian Sparber added 3 commits 5 years ago
added 3 commits

98974a20 - Add class for in-app notification

4ec520c2 - MainWindow: use in-app notification for messages

81cff134 - CallWindow: use in-app notification

Compare with previous version
Julian Sparber added 3 commits 5 years ago
added 3 commits

2318cce8 - Add class for in-app notification

21f9f9b4 - MainWindow: use in-app notification for messages

fd013f6e - CallWindow: use in-app notification

Compare with previous version
Mohammed Sadiq @mohammed.sadiq started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Julian Sparber
Last reply by Julian Sparber 5 years ago

Julian Sparber added 3 commits 5 years ago

added 3 commits

6ce3decb - Add class for in-app notification
9e6e6cbf - MainWindow: use in-app notification for messages
793c3726 - CallWindow: use in-app notification

Compare with previous version

Julian Sparber resolved all threads 5 years ago

resolved all threads

Julian Sparber added 3 commits 5 years ago

added 3 commits

8925c5b5 - Add class for in-app notification
ab1691d0 - MainWindow: use in-app notification for messages
e2c99af9 - CallWindow: use in-app notification

Compare with previous version

Julian Sparber added 3 commits 5 years ago

added 3 commits

c31df428 - Add class for in-app notification
5468c992 - MainWindow: use in-app notification for messages
518cade2 - CallWindow: use in-app notification

Compare with previous version

Julian Sparber added 4 commits 5 years ago

added 4 commits

1f985926 - 1 commit from branch Librem5:master
daebd507 - Add class for in-app notification
2902cbcc - MainWindow: use in-app notification for messages
495ae41e - CallWindow: use in-app notification

Compare with previous version

Toggle commit list

Mohammed Sadiq @mohammed.sadiq started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Julian Sparber

Mohammed Sadiq @mohammed.sadiq started a thread on an old version of the diff 5 years ago

Resolved 5 years ago by Julian Sparber

Julian Sparber added 3 commits 5 years ago

added 3 commits

706f899d - Add class for in-app notification
c8ac40c0 - MainWindow: use in-app notification for messages
bcefb1e5 - CallWindow: use in-app notification

Compare with previous version

Julian Sparber resolved all threads 5 years ago

resolved all threads

Julian Sparber @julian.sparber · 5 years ago

Author Maintainer

@mohammed.sadiq I fixed the two issues. I also changed the name of get/set_property() to calls_in_app_notification_get/set_property()

Julian Sparber added 6 commits 5 years ago

added 6 commits

bcefb1e5...cad79a48 - 3 commits from branch Librem5:master
e7e95efc - Add class for in-app notification
e7c248ea - MainWindow: use in-app notification for messages
19632e42 - CallWindow: use in-app notification

Compare with previous version

Toggle commit list

Julian Sparber mentioned in merge request !100 (merged) 5 years ago

mentioned in merge request !100 (merged)

Julian Sparber changed the description 5 years ago

changed the description

Julian Sparber changed the description 5 years ago

changed the description

Mohammed Sadiq @mohammed.sadiq · 5 years ago

Maintainer

lgtm. I could no longer reproduce the crash I had with this MR.

Julian Sparber merged 5 years ago

merged

Please register or sign in to reply