Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • chatty chatty
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 313
    • Issues 313
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • chattychatty
  • Merge requests
  • !1015

notification: escape notification message body

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Clayton Craft requested to merge craftyguy/chatty:notification_escape into master Dec 17, 2021
  • Overview 8
  • Commits 1
  • Pipelines 4
  • Changes 1

Notification daemons generally support markup in the message, and when chatty tries to send a notification with text that fails markup parsing then the notification does not contain the text at all.

E.g. receiving a SMS with the contents: "<wooohoo>" generates the following warning in Phosh:

(phosh:22722): Gtk-WARNING **: 13:57:15.935: Failed to set text '<wooohoo>' from markup due to error parsing markup: Error on line 1 char 24: Element “markup” was closed, but the currently open element is “wooohoo”

I also took the liberty to reorder the switch cases to reduce duplicate code.

Edited Dec 17, 2021 by Clayton Craft
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: notification_escape