Skip to content

fix build on GCC 10

Nikhil Jha requested to merge njha/chatty:master into master

Once again, Fedora has extremely new packages that function differently. Unlike last time though, the changes work with regular Debian gcc, so hopefully they can be merged as-is! 🎉

I'm not too familiar with C, and I'm honestly not sure why I thought of extern to fix things, but the errors I was getting were like...

/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-buddy.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:33: multiple definition of `ChattyPreferences'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:33: first defined here
/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-account.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:64: multiple definition of `e_lurch_status'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:64: first defined here
/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-account.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:56: multiple definition of `ChattyActiveAccounts'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:56: first defined here
/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-account.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:48: multiple definition of `ChattyListType'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:48: first defined here
/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-account.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:41: multiple definition of `ChattyOverlayMode'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:41: first defined here
/usr/bin/ld: src/liblibchatty.a(users_chatty-pp-account.c.o):/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:33: multiple definition of `ChattyPreferences'; src/25a6634@@chatty@exe/chatty-manager.c.o:/builddir/build/BUILD/chatty-v0.1.8/x86_64-redhat-linux-gnu/../src/chatty-window.h:33: first defined here

...so maybe there's a better way to do this?

Merge request reports