Skip to content
GitLab

WIP Make ' New chat' dialog match the parent window

Closed Guido Gunther requested to merge guido.gunther/chatty:hdy-dialog into master

This does two things

  • switch to HdyDialog (all other dialogs should do this too)
  • adds the solid-csd style class

The later makes sure there are no drop shadow. solid-csd is likely no the best thing to do, we'd rather keep the existing csd and only drop the shadows but I don't know if there's a good way in gtk+3?

Doing it this way over having the compositor maximize dialogs has the advantage that

  • small dialogs don't look totally out of place
  • the app can decide how the dialogs should look

(only the main window is maximized by the compositor initially).

It'd be cool if you could check that MR since this is currently the last known thing blocking the rootston->phoc transition. I've only changed 'new chat' as an example. Maximizing other dialogs would work the same way

cc: @tobias.bernard @adrien.plazas since the shadow problem will likely want a proper solution in GTK+

Edited by Guido Gunther