mmsd: Warn and return if recipientlist is empty
This is not supposed to happen, but seems happening, likely has to be fixed on the mmsdtng side
Fixes #611 (closed)
Merge request reports
Activity
- Resolved by Mohammed Sadiq
Yep, this fixes the crash. I can't seem to send or receive pictures to myself (They don't even show as sent).
Think this may have something do do with me being out of data on tracfone, which I'll fix later today.
- Last reply by Mohammed Sadiq
added 18 commits
-
a47f7a57...9093ced9 - 16 commits from branch
Librem5:master - 9c18079f - mmsd: Warn and return if recipientlist is empty
- 6f5b412a - mm-account: Don't proceed if chat not found
-
a47f7a57...9093ced9 - 16 commits from branch
If you like I could open up a separate issue for "Messages sent to self fail", as sending messages to one's self is not likely to be a strong use case for anyone, it's just the easiest to test out mms for the first time. However, crashing and then being unable to open is a much worse issue, as it renders chatty completely unusable.
From a usability standpoint, I think this merge request is fine. Can't speak to the codebase.
Edited by Steve Stevens@steve please be patient. Mohammed and I would rather have a proper fix and I am pretty sure I know the fix. This is not my dayjob so I will get around to it when I have time.
added 12 commits
-
6f5b412a...3b3c87d2 - 10 commits from branch
Librem5:master - 90bdd553 - mmsd: Warn and return if recipientlist is empty
- 6d1709cc - mm-account: Don't proceed if chat not found
-
6f5b412a...3b3c87d2 - 10 commits from branch
enabled an automatic merge when the pipeline for 6f976941 succeeds