Skip to content
Snippets Groups Projects
Commit be97f756 authored by Michael Catanzaro's avatar Michael Catanzaro
Browse files

embed-prefs: fix double free on error path

If we fail to create the file monitor for the user JS file, then we free
the error twice by mistake. Uh-oh. Found by Coverity.
parent a25f2906
No related branches found
No related tags found
No related merge requests found
......@@ -255,12 +255,10 @@ webkit_pref_callback_user_javascript (GSettings *settings,
(GAsyncReadyCallback)user_javascript_read_cb, NULL);
user_javascript_monitor = g_file_monitor_file (file, G_FILE_MONITOR_NONE, NULL, &error);
if (!user_javascript_monitor) {
if (!user_javascript_monitor)
g_warning ("Could not create a file monitor for %s: %s\n", g_file_get_uri (file), error->message);
g_error_free (error);
} else {
else
g_signal_connect (user_javascript_monitor, "changed", G_CALLBACK (user_javascript_file_changed), NULL);
}
}
static void
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment