Skip to content
Snippets Groups Projects
  1. Aug 29, 2022
  2. Aug 27, 2022
  3. Aug 25, 2022
  4. Aug 22, 2022
  5. Aug 21, 2022
  6. Aug 20, 2022
  7. Aug 17, 2022
  8. Aug 16, 2022
  9. Aug 11, 2022
  10. Aug 08, 2022
  11. Aug 07, 2022
  12. Aug 06, 2022
  13. Aug 05, 2022
  14. Aug 03, 2022
    • Michael Catanzaro's avatar
      window-commands: work around GTK native dialog hang · 4b1e57d4
      Michael Catanzaro authored
      When importing bookmarks, we have:
      
       (1) EphyWindow, transient parent of
       (2) GtkDialog to select where to import bookmarks from, transient
      parent of
       (3) The native file chooser dialog (in case of GVDB or HTML import)
      
      Sadly, opening a native dialog on a modal dialog hangs the application,
      gtk#5011. To dodge this problem, we can close the second dialog
      dialog when opening the third dialog, and make the EphyWindow the
      transient parent of the third dialog. This is inconvenient because it
      means you're all the way back to step one if you decide to cancel the
      third dialog and want to go back to the second dialog, but it's better
      than a hang.
      
      Exporting bookmarks does not have this problem, because there we skip
      step 2.
      
      Importing passwords does not have this problem, because there we don't
      have a native file chooser. (At least, I think so. Didn't test this
      because I do not have Chrome installed.)
      4b1e57d4
    • Michael Catanzaro's avatar
      Fix crashes and misbehavior when importing bookmarks · a22f87c8
      Michael Catanzaro authored
      We are trying to use the index of the selected item to decide what
      action to perform, but this doesn't work because not all items are
      actually present in the combo box. E.g. if there is no Firefox profile,
      it won't be present in the list. This causes the wrong codepath to be
      selected. In this bug report, the user complains that it crashes due to
      not finding any Firefox profiles when importing bookmarks from Chrome.
      
      Fixes #1800
      a22f87c8
    • Michael Catanzaro's avatar
      window-commands: fix warning when opening import dialog · ef34b5f5
      Michael Catanzaro authored
      This function is called to determine whether there exist Firefox
      profiles or not, so it'd better not warn when there are none. This
      condition can be detected via the NULL return value.
      ef34b5f5
  15. Aug 02, 2022
  16. Aug 01, 2022
  17. Jul 30, 2022
  18. Jul 29, 2022
Loading