Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
feedbackd
feedbackd
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 17
    • Issues 17
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 1
    • Merge Requests 1
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Librem5
  • feedbackdfeedbackd
  • Merge Requests
  • !46

Merged
Opened Jan 23, 2021 by Martin Bürgmann@idk.cpp
  • Report abuse
Report abuse

Fix #10 by implementing fbd_dev_sound_stop

  • Overview 34
  • Commits 1
  • Pipelines 15
  • Changes 2

Changes made:

  • moved fbd_dev_sound_stop from fbd-feedback-sound.c to fbd-dev-sound.c

  • in struct FbdDevSound new member GCancellable *playback

  • in initable_init allocating the cancellable with g_cancellable_new

  • in fbd_dev_sound_dispose disposing of the cancellable with g_clear_object

  • in fbd_dev_sound_stop cancelling the cancellable with g_cancellable_cancel but also drop the cancellable and create a new one

The recreation of the cancellable is necessary b/c the FdbDevSound object may be reused. If it is reused, the sound is immediately cancelled when started with the old cancellable.

There is the possibility to reset the cancellable but the documentation of g_cancellable_reset advises to remove the reference and create a new object.

Edited Jan 23, 2021 by Martin Bürgmann
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: Librem5/feedbackd!46