Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • feedbackd feedbackd
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • feedbackdfeedbackd
  • Merge requests
  • !74

Multicolor LED support v2

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dylan Van Assche requested to merge DylanVanAssche/feedbackd:multicolor-v2 into master May 10, 2022
  • Overview 15
  • Commits 3
  • Pipelines 6
  • Changes 3

Add support for multicolor LEDs such as from the Qualcomm LPG driver: https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=24e2d05d1b68981f22c984c766fabc5a93c83dba

This MR supersedes !41 (closed) and fixes the TODOs of !41 (closed):

  • Read multi_index so we set the colors correctly depending on the order the driver expects. On the SHIFT 6mq this is blue green red.
  • Apply max_brightness values for multi_intensity

EDIT:

  • Missing KConfig made the pattern work.
  • Added support for hw_pattern as well, LED still works now even when main SoC is suspended.
Edited May 11, 2022 by Dylan Van Assche
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: multicolor-v2