Commit a5ce9d84 authored by Michael Gratton's avatar Michael Gratton
Browse files

Components.WebView: Disable WebKitGTK sandboxing again

It breaks print-to-pdf, and the workaround effectively disables the
sandbox.

See #842 and https://bugs.webkit.org/show_bug.cgi?id=202363
parent a102c269
......@@ -79,12 +79,16 @@ public abstract class Components.WebView : WebKit.WebView, Geary.BaseInterface {
File cache_dir) {
WebsiteDataManager data_manager = new WebsiteDataManager(cache_dir.get_path());
WebKit.WebContext context = new WebKit.WebContext.with_website_data_manager(data_manager);
// Enable WebProcess sandboxing
context.add_path_to_sandbox(web_extension_dir.get_path(), true);
// Add the whole home directory otherwise print-to-PDF won't work.
// See https://bugs.webkit.org/show_bug.cgi?id=202363
context.add_path_to_sandbox(GLib.Environment.get_home_dir(), false);
context.set_sandbox_enabled(true);
// WebProcess sandboxing
//
// The sandbox is currently disabled since it breaks printing
// and saving as PDF. See:
// https://bugs.webkit.org/show_bug.cgi?id=202363
//
// context.add_path_to_sandbox(web_extension_dir.get_path(), true);
// context.set_sandbox_enabled(true);
// Use the doc browser model so that we get some caching of
// resources between email body loads.
context.set_cache_model(WebKit.CacheModel.DOCUMENT_BROWSER);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment