Skip to content
Snippets Groups Projects
  1. Aug 17, 2018
  2. Aug 16, 2018
    • Matthias Clasen's avatar
      network monitor: Update portal implementation · 7ddd1de0
      Matthias Clasen authored
      The network monitor portal interface is changing.
      Version 2 is no longer using properties, but getters
      instead (this lets the portal apply access control
      and avoid sending information to non-networked
      sandboxes).
      
      To support both version 1 and 2 of the interface,
      we stop using generated code and instead deal with
      the api differences in our own code, which is not
      too difficult.
      
      Support version 1 as well
      7ddd1de0
    • Milan Crha's avatar
      gnetworkmonitor: Fix use-after-free when using from another thread · edcce31f
      Milan Crha authored
      When using g_network_monitor_get_default() from another thread, it’s
      possible for network-changed events to be processed after an instance of
      GNetworkMonitor has been disposed, causing use-after-free problems.
      
      Fix that by moving some of the initialisation into the GInitable.init()
      chain, rather than in a main context idle callback.
      
      This includes a unit test which probabilistically reproduces the bug
      (but can’t do so deterministically due to it being a race condition).
      
      Commit amended by Philip Withnall <withnall@endlessm.com> before
      pushing.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=793727
      edcce31f
  3. Aug 09, 2018
  4. Aug 03, 2018
  5. Jun 29, 2018
  6. Jun 13, 2018
    • Philip Withnall's avatar
      Merge branch '1280-fdo-notification-glib-2-56' into 'glib-2-56' · baeaca4f
      Philip Withnall authored
      Backport "fdo notification backend: Crashes when dbus call fails" to glib-2-56
      
      See merge request GNOME/glib!102
      baeaca4f
    • Arnaud Rebillout's avatar
      gfdonotificationbackend: Fix possible invalid pointer in dbus callback · d26b66e2
      Arnaud Rebillout authored
      The way things were before: a FreedesktopNotification struct is
      allocated before the dbus call, and this same struct is possibly re-used
      for other dbus calls. If the server becomes unavailable, the callback
      will be invoked after the call times out, which leaves a long time where
      other dbus calls can happen, re-using the same FreedesktopNotification
      as user data. When the first call times out, the callback is invoked,
      and the user data is freed. Subsequent calls that used the same user
      data will time out later on, and try to free a pointer that was already
      freed, hence segfaults.
      
      This bug can be reproduced in Cinnamon 3.6.7, as mentioned in:
      <https://github.com/linuxmint/Cinnamon/issues/7491
      
      >
      
      This commit fixes that by always allocating a new
      FreedesktopNotification before invoking dbus_call(), ensuring that the
      callback always have a valid user data.
      
      Signed-off-by: default avatarArnaud Rebillout <elboulangero@gmail.com>
      d26b66e2
    • Philip Withnall's avatar
      ci: Use v3 of the Docker image for CI builds · 4a27a88d
      Philip Withnall authored
      
      Don’t update to the full CI setup from master, since its success depends
      on other fixes which are only present in master. However, using v1 of
      the Docker image is no longer possible since it’s been removed from the
      registry. Using v3 should enable CI builds for glib-2-56 to succeed.
      
      Signed-off-by: default avatarPhilip Withnall <withnall@endlessm.com>
      4a27a88d
    • Philip Withnall's avatar
      Merge branch '101-dbus-is-supported-glib-2-56' into 'glib-2-56' · 826676e8
      Philip Withnall authored
      Backport "g_dbus_is_supported_address(): set error if returning FALSE" to glib-2-56
      
      See merge request GNOME/glib!103
      826676e8
    • Will Thompson's avatar
      g_dbus_is_supported_address(): set error if returning FALSE · aaa00b5c
      Will Thompson authored
      Previously, calling:
      
          g_dbus_is_supported_address ("some-imaginary-transport:", NULL)
      
      correctly returned FALSE; but calling:
      
          g_dbus_is_supported_address ("some-imaginary-transport:", &error)
      
      crashed with:
      
          GLib-GIO:ERROR:../gio/gdbusaddress.c:434:g_dbus_is_supported_address:
          assertion failed: (ret || (!ret && (error == NULL || *error != NULL)))
      
      This was because, if the address component did not start with a known
      transport, no error was set. Fix this, reusing an error string used by
      the corresponding else branch in g_dbus_address_connect(), and adjust
      the test to pass both NULL and non-NULL GError **s to this function in
      every test case. This case:
      
          g_assert (!g_dbus_is_supported_address ("some-imaginary-transport:foo=bar;unix:path=/this/is/valid", NULL));
      
      would have caught this bug with a non-NULL GError **.
      aaa00b5c
  7. Jun 05, 2018
  8. Jun 04, 2018
  9. May 28, 2018
  10. May 22, 2018
    • Руслан Ижбулатов's avatar
      W32: check filename for being NULL in g_stat() · 0bc1e98a
      Руслан Ижбулатов authored
      Previous version of this function started with a call to g_utf8_to_utf16(),
      which also served as a NULL check, since g_utf8_to_utf16() just returns NULL
      on NULL strings. Current version of this function does some filename string
      checks first and converts it to utf16 only after these checks are done, and
      these checks do not take into account the possibility of filename being NULL.
      
      Fix this by explicitly checking for NULL.
      0bc1e98a
  11. May 04, 2018
  12. May 02, 2018
  13. Apr 26, 2018
  14. Apr 25, 2018
  15. Apr 24, 2018
  16. Apr 23, 2018
  17. Apr 20, 2018
  18. Apr 18, 2018