- Aug 17, 2018
-
-
Simon McVittie authored
-
Matthias Clasen authored
-
Matthias Clasen authored
With version 2, we need to query the values explicitly. The properties made this automatic.
-
- Aug 16, 2018
-
-
Matthias Clasen authored
The network monitor portal interface is changing. Version 2 is no longer using properties, but getters instead (this lets the portal apply access control and avoid sending information to non-networked sandboxes). To support both version 1 and 2 of the interface, we stop using generated code and instead deal with the api differences in our own code, which is not too difficult. Support version 1 as well
-
Milan Crha authored
When using g_network_monitor_get_default() from another thread, it’s possible for network-changed events to be processed after an instance of GNetworkMonitor has been disposed, causing use-after-free problems. Fix that by moving some of the initialisation into the GInitable.init() chain, rather than in a main context idle callback. This includes a unit test which probabilistically reproduces the bug (but can’t do so deterministically due to it being a race condition). Commit amended by Philip Withnall <withnall@endlessm.com> before pushing. https://bugzilla.gnome.org/show_bug.cgi?id=793727
-
- Aug 09, 2018
-
-
Ondrej Holy authored
Cherry pick GVolumeMonitor mount changes to glib-2-56 from issue #1458 See merge request GNOME/glib!224
-
Philip Withnall authored
Backport GFileInfo win32 fixes to glib-2-56 See merge request GNOME/glib!237
-
Руслан Ижбулатов authored
While mountpoints are *not* symlinks, strictly speaking, they works in a similar enough way, so consider them to be symlinks for the purpose of querying local file info.
-
Руслан Ижбулатов authored
On Windows st_ctime field is the file creation time. POSIX mandates that field to be the file state change time. Naturally, glib code interpreted st_ctime as POSIX suggested, and the result was bad. Fix this by introducing special W32-only logic for setting attributes from st_ctime field. Fixes issue #1452.
-
- Aug 03, 2018
-
-
Ondrej Holy authored
Releasing GVolumeMonitor before g_volume_mount finish cause that g_volume_get_mount returns NULL, because the mount is not correctly propagated to the volume. (Backported from commit 88b8ebb5 with minor merge conflicts.) https://gitlab.gnome.org/GNOME/glib/issues/1458
-
Ondrej Holy authored
The documentation claims that g_volume_get_mount should succeed after g_volume_mount. Let's update mounts before releasing g_volume_mount to be sure that the mount is added to the corresponding volume. The same is done in GVfsUDisks2VolumeMonitor. (Backported from commit 9b6b282e with no merge conflicts.) https://gitlab.gnome.org/GNOME/glib/issues/1458
-
- Jun 29, 2018
-
-
Ondrej Holy authored
gunixmounts: Stop considering cifs/nfs as system file systems See merge request GNOME/glib!125 (cherry picked from commit 51132b1d) a3a6c516 gunixmounts: Stop considering cifs/nfs as system file systems
-
- Jun 13, 2018
-
-
Philip Withnall authored
Backport "fdo notification backend: Crashes when dbus call fails" to glib-2-56 See merge request GNOME/glib!102
-
Arnaud Rebillout authored
The way things were before: a FreedesktopNotification struct is allocated before the dbus call, and this same struct is possibly re-used for other dbus calls. If the server becomes unavailable, the callback will be invoked after the call times out, which leaves a long time where other dbus calls can happen, re-using the same FreedesktopNotification as user data. When the first call times out, the callback is invoked, and the user data is freed. Subsequent calls that used the same user data will time out later on, and try to free a pointer that was already freed, hence segfaults. This bug can be reproduced in Cinnamon 3.6.7, as mentioned in: <https://github.com/linuxmint/Cinnamon/issues/7491 > This commit fixes that by always allocating a new FreedesktopNotification before invoking dbus_call(), ensuring that the callback always have a valid user data. Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
-
Philip Withnall authored
Don’t update to the full CI setup from master, since its success depends on other fixes which are only present in master. However, using v1 of the Docker image is no longer possible since it’s been removed from the registry. Using v3 should enable CI builds for glib-2-56 to succeed. Signed-off-by: Philip Withnall <withnall@endlessm.com>
-
Philip Withnall authored
Backport "g_dbus_is_supported_address(): set error if returning FALSE" to glib-2-56 See merge request GNOME/glib!103
-
Will Thompson authored
Previously, calling: g_dbus_is_supported_address ("some-imaginary-transport:", NULL) correctly returned FALSE; but calling: g_dbus_is_supported_address ("some-imaginary-transport:", &error) crashed with: GLib-GIO:ERROR:../gio/gdbusaddress.c:434:g_dbus_is_supported_address: assertion failed: (ret || (!ret && (error == NULL || *error != NULL))) This was because, if the address component did not start with a known transport, no error was set. Fix this, reusing an error string used by the corresponding else branch in g_dbus_address_connect(), and adjust the test to pass both NULL and non-NULL GError **s to this function in every test case. This case: g_assert (!g_dbus_is_supported_address ("some-imaginary-transport:foo=bar;unix:path=/this/is/valid", NULL)); would have caught this bug with a non-NULL GError **.
-
- Jun 05, 2018
-
-
Xavier Claessens authored
Merge branch '1401-g_clear_handle_id-clear_func-not-nullable' into 'master' See merge request GNOME/glib!56
-
- Jun 04, 2018
-
-
Philip Withnall authored
g_clear_handle_id: don't accept NULL clear_func Closes #1401 See merge request GNOME/glib!55 (cherry picked from commit 95ebaa26) 0f7c196c g_clear_handle_id: don't accept NULL clear_func
-
- May 28, 2018
-
-
Philip Withnall authored
W32: Make _g_win32_get_system_data_dirs() inline available in C++ (glib-2-56 backport) See merge request GNOME/glib!29
-
Руслан Ижбулатов authored
This way g_get_system_data_dirs() works the same way in C and C++. https://bugzilla.gnome.org/show_bug.cgi?id=777501 Closes #1240
-
- May 22, 2018
-
-
Руслан Ижбулатов authored
Previous version of this function started with a call to g_utf8_to_utf16(), which also served as a NULL check, since g_utf8_to_utf16() just returns NULL on NULL strings. Current version of this function does some filename string checks first and converts it to utf16 only after these checks are done, and these checks do not take into account the possibility of filename being NULL. Fix this by explicitly checking for NULL.
-
- May 04, 2018
-
-
Nirbheek Chauhan authored
-
Philip Withnall authored
The existing implementation was completely incorrect (despite the fix in commit 566e64a6) — it always compared GVariants by pointer, rather than by value. Reimplement it to compare them by value where possible, depending on their type. The core of this implementation is g_variant_compare(). See the documentation and tests for further details of the new sort order. This adds documentation and tests. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795735
-
Philip Withnall authored
This reverts commit 623f92ed. This fix went from one broken state to another. The real fix is to use g_variant_compare(), which is pending review. See bug #795735. https://bugzilla.gnome.org/show_bug.cgi?id=795735
-
Iñigo Martínez authored
When body file is generated, the header name to be included is built by using the path passed by `--output` directory. However, this might not be correct because, if the path includes a subdirectory, the whole path will be used instead of only the base name. Please see: https://github.com/mesonbuild/meson/issues/3488 https://github.com/gnome-mpv/gnome-mpv/issues/305#issuecomment-385056156 https://bugzilla.gnome.org/show_bug.cgi?id=795802
-
- May 02, 2018
-
-
Matthias Clasen authored
This was causing g_param_value_defaults to return 1 for GVariant values even when the value is clearly different from the default. This was showing up as gtk-builder-tool stripping non-default values for GtkActionable::action-target from ui files.
-
Christoph Reiter authored
Rebuild the fedora docker image to get the newest meson release. (Backport 2.56: Tweaked by Philip Withnall <withnall@endlessm.com> to drop MSYS2 changes.) https://bugzilla.gnome.org/show_bug.cgi?id=795711
-
- Apr 26, 2018
-
-
Philip Withnall authored
If g_get_home_dir() calculated a NULL home directory (due to $HOME being unset and /etc/passwd being inaccessible, for example due to an overly-zealous LSM), it would call g_once_init_leave (&home_dir, NULL), which would emit a critical and fail to leave the GOnce critical section. That meant that the following call to g_get_home_dir() would deadlock in g_once_init_enter(). Fix that by setting the home directory to a made-up value in such cases (which the documentation handily already explicitly allows). Thanks to Simon McVittie for the analysis leading to an easy patch. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=773435
-
Philip Withnall authored
This test will only work on machines which have IPv6 enabled and have a local IPv6 interface with ID 1. On machines which don’t (such as AWS servers, which we run CI tests on), the GResolver tests will fail with G_RESOLVER_ERROR_INVALID. We can’t differentiate this kind of failure (where we’d want to skip the test) from an actual failure (where we’d want to fail the test), so the only other option is to drop this particular test vector. I don’t think it’s a significant loss. This is the last fix needed to get our CI tests working reliably on jenkins.gnome.org. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795234
-
Philip Withnall authored
There are various reasons why setting up a server might fail; it reliably fails on AWS with IPv6 addresses (are we binding to the right address?). Since we’re trying to test GSocket as a client, skip tests where that happens. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795234
-
- Apr 25, 2018
-
-
Xavier Claessens authored
On Android _setname_ is always available but _getname_ is available only with API level >= 26. https://bugzilla.gnome.org/show_bug.cgi?id=795406
-
Xavier Claessens authored
This fix undefined symbol link error when building for non-glibc platform. Applications must link on libintl, it is not a public dependency of libglib. On glibc platforms libintl is a not found dependency and is just ignored by meson, so it doesn't hurt to always have it. https://bugzilla.gnome.org/show_bug.cgi?id=795406
-
- Apr 24, 2018
-
-
Xavier Claessens authored
This fix the build on Android r16 and older, see: https://issuetracker.google.com/issues/36987220 https://bugzilla.gnome.org/show_bug.cgi?id=740791
-
-
- Apr 23, 2018
-
-
Kentaro Hayashi authored
glib-genmarshal shows redundant "time" warning message against combination with --header and --body option. Before: WARNING: Using --header and --body at the same time time is deprecated; use --body --prototypes instead After: WARNING: Using --header and --body at the same time is deprecated; use --body --prototypes instead https://bugzilla.gnome.org/show_bug.cgi?id=795429 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
-
- Apr 20, 2018
-
-
Stas Solovey authored
-
Fabrice Fontaine authored
On gcc 4.7, we got the following error: i686-nptl-linux-gnu-gcc --version > i686-nptl-linux-gnu-gcc (crosstool-NG 1.20.0) 4.7.4 > $ echo '#include <glib-object.h>' | i686-nptl-linux-gnu-gcc -x c -I staging/usr/include/glib-2.0 -I staging/usr/lib/glib-2.0/include -Wall -Werror -c - -o /tmp/foo.o > In file included from staging/usr/include/glib-2.0/gobject/gbinding.h:29:0, > from staging/usr/include/glib-2.0/glib-object.h:23, > from <stdin>:1: > staging/usr/include/glib-2.0/gobject/gobject.h: In function 'g_set_object': > staging/usr/include/glib-2.0/gobject/gobject.h:725:5: error: value computed is not used [-Werror=unused-value] > cc1: all warnings being treated as errors This error has been added by commit 3fae39a5 So enable the new g_set_object definition only if gcc >= 4.8 Fixes: - http://autobuild.buildroot.net/results/b29a2f868438a2210873ea72f491db63175848be Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> https://bugzilla.gnome.org/show_bug.cgi?id=795138
-
- Apr 18, 2018
-
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=755721
-
Philip Withnall authored
Add a test for monitoring an existing local file, with the WATCH_HARD_LINKS flag specified. This would previously cause a crash; now it doesn’t. This test contains a FIXME where I suspect we should be getting some additional file change notifications from changes made through the hard link; this requires further follow up and probably further fixes to our inotify backend. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=755721
-