- Nov 25, 2019
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
- Nov 20, 2019
-
-
Simon McVittie authored
This is a prototype of the proposed standard build profile noinsttest. If the build profiles include both nocheck and pkg.glib2.0.noinsttest, we can drop the libdbus-1-dev build-dependency without harming test coverage or altering the contents of binary packages.
-
Simon McVittie authored
-
Simon McVittie authored
Update to upstream version '2.62.3' with Debian dir 0d10f8ccb83c7ad7d8fcb0c619290896718b1c17
-
Simon McVittie authored
-
- Nov 19, 2019
-
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com>
-
- Nov 18, 2019
-
-
Emmanuele Bassi authored
Backport !1218 “gdb: Fix GHashTable pretty printer off-by-one error” See merge request GNOME/glib!1219
-
Emmanuele Bassi authored
Backport !1221 “Add NOTE_REVOKE to the list of the monitoring events” to glib-2-62 See merge request GNOME/glib!1222
-
Emmanuele Bassi authored
Backport !1199 “gunicode: Fix UB in gutf8.c and utf8-pointer test” to glib-2-62 See merge request GNOME/glib!1228
-
- Nov 14, 2019
-
-
nightuser authored
In glib/gutf8.c there was an UB in function g_utf8_find_prev_char when p == str. In this case we substract one from p and now p points to a location outside of the boundary of str. It's a UB by the standard. Since this function are meant to be fast, we don't check the boundary conditions. Fix glib/tests/utf8-pointer test. It failed due to the UB described above and aggressive optimisation when -O2 and LTO are enabled. Some compilers (e.g. GCC with major version >= 8) create an optimised version of g_utf8_find_prev_char with the first argument fixed and stored somewhere else (with a different pointer). It can be solved with either marking str as volatile or creating a copy of str in memory. We choose the second approach since it's more explicit solution. Add additional checks to glib/tests/utf8-pointer test. Closes #1917
-
- Nov 11, 2019
-
-
Alex Samorukov authored
-
- Nov 06, 2019
-
-
Philip Chimento authored
Commit 7678b107 seems to have left the GHashTable pretty printer with an off-by-one error, skipping the first key it encounters and printing an extra garbage key/value pair instead. This fixes that by moving an increment to the end of a loop rather than the beginning.
-
Simon McVittie authored
-
Simon McVittie authored
* Update to upstream commit 2.62.2-28-g3cf25070e: - d/p/goption-Relax-assertion-to-avoid-being-broken-by-kdeinit5.patch: Fix assertion failure when called from a process that overwrites its argv, such as kdeinit5 - d/p/gdbus-peer-Specifically-listen-on-127.0.0.1.patch: Improve reliability of gdbus-peer test in some container environments - d/p/gdbusserver-Delete-socket-and-nonce-file-when-stopping-se.patch, d/p/gdbusserver-Keep-a-strong-reference-to-the-server-in-call.patch, d/p/gdbusauthmechanismsha1-Remove-unnecessary-g_warning-calls.patch, d/p/gdbusauthmechanismsha1-Create-.dbus-keyrings-directory-re.patch, d/p/tests-Move-main-loop-and-test-GUID-into-test-functions-in.patch, d/p/tests-Isolate-directories-in-gdbus-peer-test.patch, d/p/gdbus-peer-test-Improve-diagnostics-if-g_rmdir-fails.patch, d/p/gdbus-peer-test-Stop-GDBusServer-before-tearing-down-temp.patch, d/p/gdbus-peer-test-Use-unix-dir-address-if-exact-format-does.patch, d/p/gdbus-server-auth-test-Create-temporary-directory-for-Uni.patch: Mark as applied upstream in 2.62.x branch * d/p/gdbus-server-auth-test-Create-temporary-directory-for-Uni.patch: Mark as applied upstream in 2.63.x branch * Improve patch metadata: use more URLs for bug references
-
- Nov 05, 2019
-
-
Philip Withnall authored
[2.62] gdbus-peer: Specifically listen on 127.0.0.1 See merge request GNOME/glib!1215
-
- Nov 04, 2019
-
-
Simon McVittie authored
Gbp-Dch: ignore
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
This bypasses any issues we might have with containers where IPv6 is returned by name resolution (particularly since GNOME/glib!616) but doesn't necessarily actually work. This comes at a minor test-coverage cost: we don't test GDBusServer's default behaviour when told to listen on "tcp:" or "nonce-tcp:", and on systems where IPv6 is available, we don't test it. If we want to do those, we should perhaps do them in separate tests, and disable those tests when binding to ::1 doesn't work. Mitigates: GNOME/glib#1912 Signed-off-by: Simon McVittie <smcv@collabora.com> (cherry picked from commit 7021b84f)
-
Iain Lane authored
-
- Oct 31, 2019
-
-
Simon McVittie authored
Backport !1206 “goption: Relax assertion to avoid being broken by kdeinit5” to glib-2-62 See merge request GNOME/glib!1207
-
Simon McVittie authored
kdeinit5 overwrites argv, which in turn results in /proc/self/cmdline being overwritten. It seems that this is done in a way that does not necessarily guarantee that /proc/self/cmdline will end up NUL-terminated. However, g_file_get_contents() is documented to fill a buffer of size len + 1, where buffer[len] == '\0', even if the file's actual contents (from buffer[0] to buffer[len-1] inclusive) did not include a NUL; so we can safely relax this assertion slightly. Resolves: https://gitlab.gnome.org/GNOME/glib/issues/1923 Signed-off-by: Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Backport !1192, !1193, !1197 Fixes for gdbus-peer tests to glib-2-62 See merge request GNOME/glib!1203
-
Simon McVittie authored
Previously, we used unix:tmpdir, except in tests that verify that a particular address type works (notably unix:dir). Now we use unix:dir most of the time, and unix:tmpdir gets its own test instead. This helps to ensure that the tests continue to work on non-Linux Unix kernels, where abstract sockets do not exist and so unix:tmpdir is equivalent to unix:dir, even in the common case where the developer has only tried the test on Linux. Signed-off-by: Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Otherwise, since GNOME/glib!1193, the listening socket won't be deleted, and if we are not using abstract sockets (for example on *BSD), g_rmdir will fail with ENOTEMPTY. Fixes: 8e32b8e8 "gdbusserver: Delete socket and nonce file when stopping server" Resolves: GNOME/glib#1921 Signed-off-by: Simon McVittie <smcv@collabora.com>
-
Simon McVittie authored
Helps: GNOME/glib#1921 Signed-off-by: Simon McVittie <smcv@collabora.com>
-
Philip Withnall authored
The `on_run()` function could be executed in any worker thread from the `GThreadedSocketListener`, but didn’t previously hold a strong reference to the `GDBusServer`, which meant the server could be finalised in another thread while `on_run()` was still running. This was not ideal. Hold a strong reference to the `GDBusServer` while the socket listener is listening, i.e. between every paired call to `g_dbus_server_start()` and `g_dbus_server_stop()`. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1318
-
Philip Withnall authored
Rather than when finalising it. They should be automatically recreated if the server is re-started. This is important for ensuring that all externally visible behaviour of the `GDBusServer` is synchronised with calls to g_dbus_server_{start,stop}(). Finalisation of the server object could happen an arbitrarily long time after g_dbus_server_stop() is called. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1318
-
Philip Withnall authored
So that the tests all end up using separate `.dbus-keyring` directories, and hence not racing to create and acquire lock files, use `G_TEST_OPTION_ISOLATE_DIRS` to ensure they all run in separate disposable directories. This has the added benefit of meaning they don’t touch the developer’s actual `$HOME` directory. This reduces the false-failure rate of `gdbus-peer` by a factor of 9 for me on my local machine. Signed-off-by: Philip Withnall <withnall@endlessm.com> Fixes: #1912
-
Philip Withnall authored
There’s actually no need for them to be global or reused between unit tests, so move them inside the test functions. This is one step towards eliminating shared state between the unit tests. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1912
-
Philip Withnall authored
If the directory is overridden, for example when running tests, the parent directory of `.dbus-keyrings` (i.e. the fake `$HOME` directory) might not exist. Create it automatically. This should realistically not have an effect on non-test code. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1912
-
Philip Withnall authored
These can be hit in the tests (if multiple tests run in parallel are racing for `~/.dbus-keyrings/org_gtk_gdbus_general.lock` for a prolonged period) and will cause spurious test failures due to the use of `G_DEBUG=fatal-warnings`. Instead, allow the error messages to be inspected programmatically. Signed-off-by: Philip Withnall <withnall@endlessm.com> Helps: #1912
-
- Oct 30, 2019
-
-
Simon McVittie authored
-
Simon McVittie authored
-
- Oct 29, 2019
-
-
Simon McVittie authored
-
Simon McVittie authored
-