client: Make CmCallback work like other glib callbacks
Instead of passing the user_data as first argument, pass it as last
argument like anywhere else. Instead we have the client
as first
argument as one would expect.
Remove mentions of user_data
being a GObject
requirement. It's an
untyped pointer as user_data
elsewhere.
This is a slight API break but it makes things less confusing (at least for me).
As I always get stuck on gpointer object
and similar things.
Merge request reports
Activity
added breaking label
- Resolved by Guido Günther
- Resolved by Guido Günther
added 1 commit
- 76494808 - client: Make CmCallback work like other glib callbacks
v1.1
- Don't name a
gpointer
object
in example (thanks @evangelos.tzaras)
- Don't name a
mentioned in merge request !69 (merged)
mentioned in merge request !72 (merged)
- Resolved by Guido Günther
it would be nice to have this for 0.0.2
we could maybe start thinking about maintaing a shared library as well at some point.
mentioned in merge request !87 (merged)
added 82 commits
-
79e31866...1a522658 - 79 commits from branch
Librem5:main
- c166404a - client: Make CmCallback work like other glib callbacks
- ed113c87 - cm-client: Allow to pass `NULL` callback
- 089b08e6 - client: Ensure callback is stopped and it's data free'd on finalize
Toggle commit list-
79e31866...1a522658 - 79 commits from branch
Rebased to make gitlab happy (
no conflicts, just gitlab being overly cautious)EDIT: Actually not true, my main was just a bit dated. Fixed now.
Edited by Guido Güntheradded 9 commits
-
089b08e6...3f6b4d9d - 6 commits from branch
Librem5:main
- ba5f30c7 - client: Make CmCallback work like other glib callbacks
- 028260f1 - cm-client: Allow to pass `NULL` callback
- 826d7061 - client: Ensure callback is stopped and it's data free'd on finalize
Toggle commit list-
089b08e6...3f6b4d9d - 6 commits from branch
v1.3
- Really allow to pass
NULL
as callback
Edited by Guido Günther- Really allow to pass
Tested now with eigenvalue (!66 (merged)) so should be good to go. Needs mention in #38 (closed)
Edited by Guido Günthermentioned in issue #38 (closed)
added 9 commits
-
62871ea7...6bc48a97 - 6 commits from branch
Librem5:main
- 2cc13d50 - client: Make CmCallback work like other glib callbacks
- 7b198f48 - cm-client: Allow to pass `NULL` callback
- 74e2bb71 - client: Ensure callback is stopped and it's data free'd on finalize
Toggle commit list-
62871ea7...6bc48a97 - 6 commits from branch