Skip to content
Snippets Groups Projects

client: Make CmCallback work like other glib callbacks

Merged Guido Günther requested to merge agx/libcmatrix:docs into main

Instead of passing the user_data as first argument, pass it as last argument like anywhere else. Instead we have the client as first argument as one would expect.

Remove mentions of user_data being a GObject requirement. It's an untyped pointer as user_data elsewhere.

This is a slight API break but it makes things less confusing (at least for me). As I always get stuck on gpointer object and similar things.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Evangelos Ribeiro Tzaras
  • added 1 commit

    • 76494808 - client: Make CmCallback work like other glib callbacks

    Compare with previous version

  • v1.1

  • mentioned in merge request !69 (merged)

  • Guido Günther mentioned in merge request !72 (merged)

    mentioned in merge request !72 (merged)

  • Guido Günther mentioned in merge request !87 (merged)

    mentioned in merge request !87 (merged)

  • Guido Günther added 2 commits

    added 2 commits

    • 1436fc67 - cm-client: Allow to pass `NULL` callback
    • 79e31866 - client: Ensure callback is stopped and it's data free'd on finalize

    Compare with previous version

  • Guido Günther added 82 commits

    added 82 commits

    • 79e31866...1a522658 - 79 commits from branch Librem5:main
    • c166404a - client: Make CmCallback work like other glib callbacks
    • ed113c87 - cm-client: Allow to pass `NULL` callback
    • 089b08e6 - client: Ensure callback is stopped and it's data free'd on finalize

    Compare with previous version

  • Guido Günther resolved all threads

    resolved all threads

  • Rebased to make gitlab happy (no conflicts, just gitlab being overly cautious)

    EDIT: Actually not true, my main was just a bit dated. Fixed now.

    Edited by Guido Günther
  • Guido Günther added 9 commits

    added 9 commits

    • 089b08e6...3f6b4d9d - 6 commits from branch Librem5:main
    • ba5f30c7 - client: Make CmCallback work like other glib callbacks
    • 028260f1 - cm-client: Allow to pass `NULL` callback
    • 826d7061 - client: Ensure callback is stopped and it's data free'd on finalize

    Compare with previous version

  • Guido Günther added 2 commits

    added 2 commits

    • dd50bd8f - cm-client: Allow to pass `NULL` callback
    • 62871ea7 - client: Ensure callback is stopped and it's data free'd on finalize

    Compare with previous version

  • v1.3

    • Really allow to pass NULL as callback
    Edited by Guido Günther
  • Tested now with eigenvalue (!66 (merged)) so should be good to go. Needs mention in #38 (closed)

    Edited by Guido Günther
  • mentioned in issue #38 (closed)

  • Guido Günther added 9 commits

    added 9 commits

    • 62871ea7...6bc48a97 - 6 commits from branch Librem5:main
    • 2cc13d50 - client: Make CmCallback work like other glib callbacks
    • 7b198f48 - cm-client: Allow to pass `NULL` callback
    • 74e2bb71 - client: Ensure callback is stopped and it's data free'd on finalize

    Compare with previous version

  • Let's get this API break out of the way then so we have all known ones in place for 0.0.2

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading