Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • libhandy libhandy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 131
    • Issues 131
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Librem5
  • libhandylibhandy
  • Merge requests
  • !177

leaflet: Clear the children list on disposal

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adrien Plazas requested to merge adrien.plazas/libhandy:leaflet-fix into master Dec 13, 2018
  • Overview 6
  • Commits 1
  • Pipelines 5
  • Changes 1

This hopefully fixes #42 (closed).

I can't be sure if it fixes it as we didn't manage to reproduce the issue in a sure way.

To test it and be confident it should solve the issue, I added this at the top of hdy_leaflet_forall():

  if (callback == gtk_widget_destroy)
    g_assert (priv->children == NULL);

Without the fix, the assertion is always false, and with it it seems to only be true, so it should work.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: leaflet-fix