While we run the static analyzer warnings weren't fatal. Fix this.
We can't merge it yet since it fails like
[16/58] Compiling C object 'src/25a6634@@handy-0.0@sha/hdy-combo-row.c.o'. ../../../src/hdy-combo-row.c:447:1: warning: Potential leak of memory pointed to by 'data' } ^ 1 warning generated. [18/58] Compiling C object 'src/25a6634@@handy-0.0@sha/hdy-dialer-button.c.o'. ../../../src/hdy-dialer-button.c:57:3: warning: Potential leak of memory pointed to by 'text' gtk_label_set_label (priv->secondary_label, secondary_text); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated.
Which are false positives AFAIKT. Seems Qt has similar issues and we need to teach the analyzer about
Maybe someone with a crush on clang wants to pick this up?