Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • libhandy libhandy
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 131
    • Issues 131
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • Librem5
  • libhandylibhandy
  • Merge requests
  • !309

HdySwipeGroup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Mikhaylenko requested to merge exalm/libhandy:wip/exalm/sync into master Aug 26, 2019
  • Overview 49
  • Commits 9
  • Pipelines 13
  • Changes 20

This is an RFC, adds a HdySwipeable interface (currently HdyPaginator implements it), and a HdySwipeGroup object for syncing multiple widgets together.

This will be necessary for swipeable HdyLeaflet later, to sync content and headerbar, but for now I have some doubts about HdySwipeGroup API.

  1. Should the API use Swipeable or Widget naming, i.e. hdy_swipe_group_add_swipeable() or hdy_swipe_group_add_widget()? The second sounds a lot better to me, but it requires a HdySwipeable, not any random GtkWidget. (though swipeable must be widget) swipeable
  2. Does it makes sense to have HdySwipeTracker use HdySwipeable internally? it's fine
  3. Currently HdySwipeGroup is derivable, just like HdyHeaderGroup was. I seriously doubt it needs to be derivable. :) (both of them, really, but changing HdyHeaderGroup at this point would be an ABI break) final

There's a rudimentary example in the libhandy demo, will remove it later.

(yes, I know it's missing docs and tests atm)

Edited Oct 26, 2019 by Alexander Mikhaylenko
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: wip/exalm/sync