Skip to content
Snippets Groups Projects

example: Use separators to separate the panels

Merged Adrien Plazas requested to merge adrien.plazas/libhandy:separators into master
All threads resolved!

Use a GtkSeparator to separate the stack sidebar from the various demo widgets, use custom styling to make the sidebar not draw its own separator, and move the start of the header bar and the header bar separator out of their box and directly into the leaflet.

This allows to have the separators well aligned with no workaround other than a simple custom style, to have no separator appearing when the window is folded, and to not trigger the GTK+ bug making titlebar separators appear black.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good besides the above minor nit.

  • Adrien Plazas added 2 commits

    added 2 commits

    • 92b8947b - example: Load custom style from CSS resource
    • 6549c32d - example: Use separators to separate the panels

    Compare with previous version

  • I was thinking: what about adding this custom style to libhandy itself and not to the demo application? We will need to load more custom styling for HdyTitleBar that I am going to push soonish anyway.

    We could load it in hdy_init() for example.

    That way all users of libhandy would have the same style fixes.

    Edited by Adrien Plazas
  • Adrien Plazas added 3 commits

    added 3 commits

    • 6b5a7712 - 1 commit from branch Librem5:master
    • fbc4fcc6 - example: Load custom style from CSS resource
    • 3b490942 - example: Use separators to separate the panels

    Compare with previous version

  • Adrien Plazas added 2 commits

    added 2 commits

    • bb16d40b - example: Load custom style from CSS resource
    • 7023fae9 - example: Use separators to separate the panels

    Compare with previous version

  • Adrien Plazas resolved all discussions

    resolved all discussions

  • Adrien Plazas mentioned in merge request !104 (merged)

    mentioned in merge request !104 (merged)

  • Actually I changed my mind: let's ship these theming fixes downstream for the moment while I am working on pushing them in Adwaita for GTK+ 3.24.1, then we will be able to drop them downstream iff they end up being accepted upstream.

    In other words, feel free to merge this. :)

  • Adrien Plazas added 2 commits

    added 2 commits

    • c605d14b - example: Draw the right color for sidebar separators
    • a0e1d1b1 - example: Use separators to separate the panels

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading