Skip to content
Snippets Groups Projects

Normalize and document private header guards

Merged Normalize and document private header guards
adrien.plazas/libhandy:inside-compilation into master
1 unresolved thread
Merged Adrien Plazas requested to merge adrien.plazas/libhandy:inside-compilation into master
1 unresolved thread

Merge request reports

Pipeline #2177 passed

Stage: build

    Pipeline passed for e7812490 on adrien.plazas:inside-compilation

    Test coverage 25.40% (0.00%) from 1 job
    Approved by
    Guido Gunther

    Merged by Guido GuntherGuido Gunther 6 years ago (Dec 3, 2018 9:50am UTC)

    Merge details

    • Changes merged into master with e7812490.
    • Deleted the source branch.
    • Auto-merge enabled

    Pipeline #2179 passed

    Stage: build

      Pipeline passed for e7812490 on master

      Test coverage 25.40% (0.00%) from 1 job

      Activity

      Filter activity
      • Approvals
      • Assignees & reviewers
      • Comments (from bots)
      • Comments (from users)
      • Commits & branches
      • Edits
      • Labels
      • Lock status
      • Mentions
      • Merge request status
      • Tracking
    • Guido Gunther
    • Adrien Plazas added 1 commit

      added 1 commit

      • e109a941 - Normalize and document private header guards

      Compare with previous version

    • Adrien Plazas resolved all discussions

      resolved all discussions

    • Guido Gunther
      Guido Gunther @guido.gunther started a thread on an old version of the diff
      • HACKING.md
      75 75 Guard header inclusion with `#pragma once` rather than the traditional
      76 76 `#ifndef`-`#define`-`#endif` trio.
      77 77
      78 Internal headers (whether they need to be installed or not) should contain the
    • Guido Gunther
      Guido Gunther @guido.gunther ·
      Owner

      Code looks good otherwise!

    • Adrien Plazas added 8 commits

      added 8 commits

      Compare with previous version

    • Adrien Plazas added 1 commit

      added 1 commit

      • a5133996 - Normalize and document private header guards

      Compare with previous version

    • Guido Gunther approved this merge request

      approved this merge request

    • Guido Gunther added 8 commits

      added 8 commits

      Compare with previous version

    • Guido Gunther enabled an automatic merge when the pipeline for e7812490 succeeds

      enabled an automatic merge when the pipeline for e7812490 succeeds

    • Guido Gunther merged

      merged

      • Please register or sign in to reply