leaflet: Dim bottom children during transitions

By request of @adrien.plazas :p

---

Update: mode transitions too.

added 2 commits

• 947a2169 - 1 commit from branch Librem5:master
• a544705d - leaflet: Dim bottom child during child transitions

Compare with previous version

What's the point of the SHADOW_GRADIENT_OFFSETS and SHADOW_GRADIENT_ALPHA macros? Is it to be consistent with magic numbers definitions being macros?

BTW where do these magic values come from? Did you find them in WebKitGTK? It would be nice to note where these values come from or how you computed them so we can keep them in sync with their source or edit them if needed.

Hm, I've been meaning to ask how to #define an array in C. I think I just use the const arrays, right?

The values are from WebKitGTK, yes. Those, in turn, are same as in Mac gesture, since I reused the same constants for that gesture (which is why I've been asking if you actually want them to be in libhandy/GTK)

It's mentioned in commit message, would you prefer a comment?

You could just use a static const array but I'm not opposed to what you did. If you drop the macro make the static const array's name uppercase to denote it's a static constant.

A comment would make more sense than a commit message but having that in a commit message too doesn't hurt.

added 1 commit

• f2e88b6a - leaflet: Dim bottom child during child transitions

Compare with previous version

changed milestone to %1.0

mentioned in merge request !230 (merged)

mentioned in issue #78

added 26 commits

• f2e88b6a...56b0aa62 - 25 commits from branch Librem5:master
• 2a450112 - leaflet: Dim bottom child during child transitions

Compare with previous version

added 2 commits

• 745902cc - leaflet: Only clip visible area during transitions
• 1294c734 - leaflet: Dim bottom child during child transitions

Compare with previous version

resolved all discussions

added 109 commits

• 1294c734...f5909a89 - 107 commits from branch Librem5:master
• 81849d0e - leaflet: Only clip visible area during transitions
• bf1a7ef3 - leaflet: Dim bottom child during child transitions

Compare with previous version

added 3 commits

• 1d47eeb8 - 1 commit from branch Librem5:master
• de0de56f - leaflet: Only clip visible area during transitions
• d35c7353 - leaflet: Dim bottom child during child transitions

Compare with previous version

added 1 commit

• 46db89a4 - leaflet: Dim bottom child during child transitions

Compare with previous version

added 1 commit

• a8599bae - leaflet: Dim bottom child during child transitions

Compare with previous version

Nice to see you working on that again! Let me know when it's ready to be reviewed.

resolved all threads

Ah, I synced it with webkit changes. :) Though it needs optimization, similarly to webkit: caching the surfaces from foreign drawing.

mentioned in issue #154 (closed)

added 21 commits

• a8599bae...9ecbf214 - 19 commits from branch Librem5:master
• 6097f627 - leaflet: Only clip visible area during transitions
• ae507040 - leaflet: Dim bottom child during child transitions

Compare with previous version

Added caching. I wonder if the shadow-related stuff should be in its own file, it's pretty invasive now.

removed milestone

added 7 commits

• ae507040...9c6e1b76 - 4 commits from branch Librem5:master
• a6b8c61a - leaflet: Only clip visible area during transitions
• 34b3db50 - leaflet: Dim bottom child during child transitions
• 3b8a0c8d - leaflet: Use shadow during mode transitions

Compare with previous version

Added shadow for mode transitions as well.

added 3 commits

• cdbc42ab - leaflet: Only clip visible area during transitions
• 050563ce - leaflet: Dim bottom child during child transitions
• bb7b6088 - leaflet: Use shadow during mode transitions

Compare with previous version

added 3 commits

• bc25f9bb - leaflet: Only clip visible area during transitions
• 54b391ec - Introduce HdyShadowHelper
• daff201f - leaflet: Dim bottom children during transitions

Compare with previous version

added 2 commits

• 6df7cd83 - Introduce HdyShadowHelper
• b2144756 - leaflet: Dim bottom children during transitions

Compare with previous version

resolved all threads

I forgot that I now use fixed distance for the shadow and did it the old way for mode transitions. Fixed now, they look properly.

Moved shadow logic to a separate class.

changed title from leaflet: Dim bottom child during child transitions to leaflet: Dim bottom children during transitions

changed the description

I didn't read through the algorithmic parts in depth, but on the surface it looks good. :)

added 2 commits

• 383f11de - Introduce HdyShadowHelper
• 32176099 - leaflet: Dim bottom children during transitions

Compare with previous version

resolved all threads

merged