Skip to content
Snippets Groups Projects

Fails builds on warnings and warn on possibly uninitialized variables

Merged Guido Gunther requested to merge guido.gunther/libhandy:warning-fixes into master

@adrien.plazas please look at the third patch. At least one of them looks like a real omission which I've so far just pampered over.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The capitalization on the commit logs is unconsistent, you should add a capital to Warn in meson: warn about possible uninitialized variables. I let many of these slip through to not bother you in the previous MRs, I hope you won't mind if I become a bit more pedantic about these ones from now on. :x

    Beside that it looks great to me. :)

    Unfortunately I can't merge it, I see Fast-forward merge is not possible. Rebase the source branch onto master to allow this merge request to be merged. message.

  • Guido Gunther added 4 commits

    added 4 commits

    • 8de98df8 - 1 commit from branch Librem5:master
    • 57a0808a - gitlab-ci: Fail on compile warnings
    • c8262d55 - meson: Warn about possible uninitialized variables
    • c538893b - HdyLeaflet: Fix two uninitialized variables

    Compare with previous version

  • I'm happy to fix up commit messages when the code is alright. Did you look at the third patch and check that it doesn't paper over a deeper problem in HdyLeaflet?

    I changed this repo to require fast-forwardable MRs, we can also enable the rebase button but I would prefer if people recheck their MRs if their outdated for the moment. O.k.?

  • These changes should be fine as you filled them up with "default" values. If bugs occur later, at least they will be consistent thanks to your changes. :)

    I would prefer if people recheck their MRs if their outdated for the moment. O.k.?

    I'm fine with that. It is convenient when the diversiond are completely unrelated but for the moment libhandy is low traffic and mostly just the two of us so it's fine.

  • merged

Please register or sign in to reply
Loading