Skip to content
Snippets Groups Projects
Commit b4b9c3d7 authored by Guido Gunther's avatar Guido Gunther :zzz: Committed by Martin Kepplinger
Browse files

pytest: Don't fail touch test on devkit

The file doesn't exist there and throws and we get an error.
parent 6b95297c
No related branches found
No related tags found
2 merge requests!202Switch ci to byzantium too and release,!191pytest: Don't fail touch test on devkit
Pipeline #62232 passed
......@@ -4,8 +4,11 @@ import pytest
def read_firmware_version():
with open('/sys/kernel/debug/edt_ft5x06/fw_version') as f:
return int(f.read())
try:
with open('/sys/kernel/debug/edt_ft5x06/fw_version') as f:
return int(f.read())
except Exception:
return 0
@pytest.mark.skipif(not boardtype.is_librem5(), reason="Not a phone")
......
  • Sebastian Krzyszkowiak @sebastian.krzyszkowiak ·
    Owner

    Shouldn't that be skipped already due to @pytest.mark.skipif(not boardtype.is_librem5(), reason="Not a phone")?

  • Guido Gunther :zzz: @guido.gunther ·
    Author Owner

    it seems both skipifs are evaluated (independent of order)

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment