Skip to content
  • Yang Shi's avatar
    bpf: convert hashtab lock to raw lock · ac00881f
    Yang Shi authored
    When running bpf samples on rt kernel, it reports the below warning:
    
    BUG: sleeping function called from invalid context at kernel/locking/rtmutex.c:917
    in_atomic(): 1, irqs_disabled(): 128, pid: 477, name: ping
    Preemption disabled at:[<ffff80000017db58>] kprobe_perf_func+0x30/0x228
    
    CPU: 3 PID: 477 Comm: ping Not tainted 4.1.10-rt8 #4
    
    
    Hardware name: Freescale Layerscape 2085a RDB Board (DT)
    Call trace:
    [<ffff80000008a5b0>] dump_backtrace+0x0/0x128
    [<ffff80000008a6f8>] show_stack+0x20/0x30
    [<ffff8000007da90c>] dump_stack+0x7c/0xa0
    [<ffff8000000e4830>] ___might_sleep+0x188/0x1a0
    [<ffff8000007e2200>] rt_spin_lock+0x28/0x40
    [<ffff80000018bf9c>] htab_map_update_elem+0x124/0x320
    [<ffff80000018c718>] bpf_map_update_elem+0x40/0x58
    [<ffff800000187658>] __bpf_prog_run+0xd48/0x1640
    [<ffff80000017ca6c>] trace_call_bpf+0x8c/0x100
    [<ffff80000017db58>] kprobe_perf_func+0x30/0x228
    [<ffff80000017dd84>] kprobe_dispatcher+0x34/0x58
    [<ffff8000007e399c>] kprobe_handler+0x114/0x250
    [<ffff8000007e3bf4>] kprobe_breakpoint_handler+0x1c/0x30
    [<ffff800000085b80>] brk_handler+0x88/0x98
    [<ffff8000000822f0>] do_debug_exception+0x50/0xb8
    Exception stack(0xffff808349687460 to 0xffff808349687580)
    7460: 4ca2b600 ffff8083 4a3a7000 ffff8083 49687620 ffff8083 0069c5f8 ffff8000
    7480: 00000001 00000000 007e0628 ffff8000 496874b0 ffff8083 007e1de8 ffff8000
    74a0: 496874d0 ffff8083 0008e04c ffff8000 00000001 00000000 4ca2b600 ffff8083
    74c0: 00ba2e80 ffff8000 49687528 ffff8083 49687510 ffff8083 000e5c70 ffff8000
    74e0: 00c22348 ffff8000 00000000 ffff8083 49687510 ffff8083 000e5c74 ffff8000
    7500: 4ca2b600 ffff8083 49401800 ffff8083 00000001 00000000 00000000 00000000
    7520: 496874d0 ffff8083 00000000 00000000 00000000 00000000 00000000 00000000
    7540: 2f2e2d2c 33323130 00000000 00000000 4c944500 ffff8083 00000000 00000000
    7560: 00000000 00000000 008751e0 ffff8000 00000001 00000000 124e2d1d 00107b77
    
    Convert hashtab lock to raw lock to avoid such warning.
    
    Signed-off-by: default avatarYang Shi <yang.shi@linaro.org>
    Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ac00881f