Skip to content
  • Peter Zijlstra's avatar
    perf/x86/BTS: Fix RCU usage · e8d8a90f
    Peter Zijlstra authored
    
    
    This splat reminds us:
    
    [ 8166.045595] [ INFO: suspicious RCU usage. ]
    
    [ 8166.168972]  [<ffffffff81127837>] lockdep_rcu_suspicious+0xe7/0x120
    [ 8166.175966]  [<ffffffff811e0bae>] perf_callchain+0x23e/0x250
    [ 8166.182280]  [<ffffffff811dda3d>] perf_prepare_sample+0x27d/0x350
    [ 8166.189082]  [<ffffffff8100f503>] intel_pmu_drain_bts_buffer+0x133/0x200
    
    ... that as the core code does, one should hold rcu_read_lock() over that
    entire BTS event-output generation sequence as well.
    
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    e8d8a90f