switch ->setxattr() to passing dentry and inode separately
smack ->d_instantiate() uses ->setxattr(), so to be able to call it before we'd hashed the new dentry and attached it to inode, we need ->setxattr() instances getting the inode as an explicit argument rather than obtaining it from dentry. Similar change for ->getxattr() had been done in commit ce23e640. Unlike ->getxattr() (which is used by both selinux and smack instances of ->d_instantiate()) ->setxattr() is used only by smack one and unfortunately it got missed back then. Reported-by:Seung-Woo Kim <sw0312.kim@samsung.com> Tested-by:
Casey Schaufler <casey@schaufler-ca.com> Signed-off-by:
Al Viro <viro@zeniv.linux.org.uk>
Showing
- Documentation/filesystems/porting 7 additions, 0 deletionsDocumentation/filesystems/porting
- drivers/staging/lustre/lustre/llite/llite_internal.h 2 additions, 2 deletionsdrivers/staging/lustre/lustre/llite/llite_internal.h
- drivers/staging/lustre/lustre/llite/xattr.c 2 additions, 4 deletionsdrivers/staging/lustre/lustre/llite/xattr.c
- fs/bad_inode.c 2 additions, 2 deletionsfs/bad_inode.c
- fs/ecryptfs/crypto.c 5 additions, 4 deletionsfs/ecryptfs/crypto.c
- fs/ecryptfs/ecryptfs_kernel.h 2 additions, 2 deletionsfs/ecryptfs/ecryptfs_kernel.h
- fs/ecryptfs/inode.c 4 additions, 3 deletionsfs/ecryptfs/inode.c
- fs/ecryptfs/mmap.c 2 additions, 1 deletionfs/ecryptfs/mmap.c
- fs/fuse/dir.c 3 additions, 3 deletionsfs/fuse/dir.c
- fs/hfs/attr.c 3 additions, 3 deletionsfs/hfs/attr.c
- fs/hfs/hfs_fs.h 1 addition, 1 deletionfs/hfs/hfs_fs.h
- fs/kernfs/inode.c 6 additions, 5 deletionsfs/kernfs/inode.c
- fs/kernfs/kernfs-internal.h 2 additions, 1 deletionfs/kernfs/kernfs-internal.h
- fs/libfs.c 3 additions, 2 deletionsfs/libfs.c
- fs/overlayfs/inode.c 3 additions, 2 deletionsfs/overlayfs/inode.c
- fs/overlayfs/overlayfs.h 3 additions, 2 deletionsfs/overlayfs/overlayfs.h
- fs/xattr.c 4 additions, 4 deletionsfs/xattr.c
- include/linux/fs.h 2 additions, 1 deletioninclude/linux/fs.h
- include/linux/xattr.h 2 additions, 1 deletioninclude/linux/xattr.h
- security/smack/smack_lsm.c 1 addition, 1 deletionsecurity/smack/smack_lsm.c
Loading
Please register or sign in to comment