Merge branch 'net-stmmac-Stop-using-hard-coded-callbacks'
Jose Abreu says:
====================
net: stmmac: Stop using hard-coded callbacks
This a starting point for a cleanup and re-organization of stmmac.
In this series we stop using hard-coded callbacks along the code and use
instead helpers which are defined in a single place ("hwif.h").
This brings several advantages:
1) Less typing :)
2) Guaranteed function pointer check
3) More flexibility
By 2) we stop using the repeated pattern of:
if (priv->hw->mac->some_func)
priv->hw->mac->some_func(...)
I didn't check but I expect the final .ko will be bigger with this series
because *all* of function pointers are checked.
Anyway, I hope this can make the code more readable and more flexible now.
====================
Signed-off-by:
David S. Miller <davem@davemloft.net>
No related branches found
No related tags found
Showing
- drivers/net/ethernet/stmicro/stmmac/chain_mode.c 16 additions, 18 deletionsdrivers/net/ethernet/stmicro/stmmac/chain_mode.c
- drivers/net/ethernet/stmicro/stmmac/common.h 1 addition, 198 deletionsdrivers/net/ethernet/stmicro/stmmac/common.h
- drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c 2 additions, 2 deletionsdrivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c
- drivers/net/ethernet/stmicro/stmmac/dwmac5.c 11 additions, 8 deletionsdrivers/net/ethernet/stmicro/stmmac/dwmac5.c
- drivers/net/ethernet/stmicro/stmmac/dwmac5.h 3 additions, 3 deletionsdrivers/net/ethernet/stmicro/stmmac/dwmac5.h
- drivers/net/ethernet/stmicro/stmmac/enh_desc.c 2 additions, 2 deletionsdrivers/net/ethernet/stmicro/stmmac/enh_desc.c
- drivers/net/ethernet/stmicro/stmmac/hwif.h 421 additions, 0 deletionsdrivers/net/ethernet/stmicro/stmmac/hwif.h
- drivers/net/ethernet/stmicro/stmmac/norm_desc.c 2 additions, 2 deletionsdrivers/net/ethernet/stmicro/stmmac/norm_desc.c
- drivers/net/ethernet/stmicro/stmmac/ring_mode.c 18 additions, 21 deletionsdrivers/net/ethernet/stmicro/stmmac/ring_mode.c
- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c 31 additions, 51 deletionsdrivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
- drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c 18 additions, 16 deletionsdrivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 196 additions, 243 deletionsdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c
- drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c 5 additions, 13 deletionsdrivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
Loading
Please register or sign in to comment