net: relax setup_tc ndo op handle restriction
I added this check in setup_tc to multiple drivers, if (handle != TC_H_ROOT || tc->type != TC_SETUP_MQPRIO) Unfortunately restricting to TC_H_ROOT like this breaks the old instantiation of mqprio to setup a hardware qdisc. This patch relaxes the test to only check the type to make it equivalent to the check before I broke it. With this the old instantiation continues to work. A good smoke test is to setup mqprio with, # tc qdisc add dev eth4 root mqprio num_tc 8 \ map 0 1 2 3 4 5 6 7 \ queues 0@0 1@1 2@2 3@3 4@4 5@5 6@6 7@7 Fixes: e4c6734e ("net: rework ndo tc op to consume additional qdisc handle paramete") Reported-by:Singh Krishneil <krishneil.k.singh@intel.com> Reported-by:
Jake Keller <jacob.e.keller@intel.com> CC: Murali Karicheri <m-karicheri2@ti.com> CC: Shradha Shah <sshah@solarflare.com> CC: Or Gerlitz <ogerlitz@mellanox.com> CC: Ariel Elior <ariel.elior@qlogic.com> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com> CC: Bruce Allan <bruce.w.allan@intel.com> CC: Jesse Brandeburg <jesse.brandeburg@intel.com> CC: Don Skidmore <donald.c.skidmore@intel.com> Signed-off-by:
John Fastabend <john.r.fastabend@intel.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- drivers/net/ethernet/amd/xgbe/xgbe-drv.c 1 addition, 1 deletiondrivers/net/ethernet/amd/xgbe/xgbe-drv.c
- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c 1 addition, 1 deletiondrivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c
- drivers/net/ethernet/broadcom/bnxt/bnxt.c 1 addition, 1 deletiondrivers/net/ethernet/broadcom/bnxt/bnxt.c
- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c 1 addition, 1 deletiondrivers/net/ethernet/intel/fm10k/fm10k_netdev.c
- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c 1 addition, 1 deletiondrivers/net/ethernet/intel/ixgbe/ixgbe_main.c
- drivers/net/ethernet/mellanox/mlx4/en_netdev.c 1 addition, 1 deletiondrivers/net/ethernet/mellanox/mlx4/en_netdev.c
- drivers/net/ethernet/sfc/tx.c 1 addition, 1 deletiondrivers/net/ethernet/sfc/tx.c
- drivers/net/ethernet/ti/netcp_core.c 1 addition, 1 deletiondrivers/net/ethernet/ti/netcp_core.c
Loading
Please register or sign in to comment