parisc: Make struct parisc_driver::remove() return void
The caller of this function (parisc_driver_remove() in arch/parisc/kernel/drivers.c) ignores the return value, so better don't return any value at all to not wake wrong expectations in driver authors. The only function that could return a non-zero value before was ipmi_parisc_remove() which returns the return value of ipmi_si_remove_by_dev(). Make this function return void, too, as for all other callers the value is ignored, too. Also fold in a small checkpatch fix for: WARNING: Unnecessary space before function pointer arguments + void (*remove) (struct parisc_device *dev); Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input) Signed-off-by:Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by:
Sudip Mukherjee <sudipm.mukherjee@gmail.com> Acked-by:
Jiri Slaby <jirislaby@kernel.org> Signed-off-by:
Helge Deller <deller@gmx.de>
Showing
- arch/parisc/include/asm/parisc-device.h 2 additions, 2 deletionsarch/parisc/include/asm/parisc-device.h
- drivers/char/ipmi/ipmi_si.h 1 addition, 1 deletiondrivers/char/ipmi/ipmi_si.h
- drivers/char/ipmi/ipmi_si_intf.c 1 addition, 5 deletionsdrivers/char/ipmi/ipmi_si_intf.c
- drivers/char/ipmi/ipmi_si_parisc.c 2 additions, 2 deletionsdrivers/char/ipmi/ipmi_si_parisc.c
- drivers/char/ipmi/ipmi_si_platform.c 3 additions, 1 deletiondrivers/char/ipmi/ipmi_si_platform.c
- drivers/input/keyboard/hilkbd.c 1 addition, 3 deletionsdrivers/input/keyboard/hilkbd.c
- drivers/input/serio/gscps2.c 1 addition, 2 deletionsdrivers/input/serio/gscps2.c
- drivers/net/ethernet/i825xx/lasi_82596.c 1 addition, 2 deletionsdrivers/net/ethernet/i825xx/lasi_82596.c
- drivers/parport/parport_gsc.c 1 addition, 2 deletionsdrivers/parport/parport_gsc.c
- drivers/scsi/lasi700.c 1 addition, 3 deletionsdrivers/scsi/lasi700.c
- drivers/scsi/zalon.c 1 addition, 3 deletionsdrivers/scsi/zalon.c
- drivers/tty/serial/mux.c 1 addition, 2 deletionsdrivers/tty/serial/mux.c
- sound/parisc/harmony.c 1 addition, 2 deletionssound/parisc/harmony.c
Loading
Please register or sign in to comment