net: bridge: mcast: add and enforce query interval minimum
As reported[1] if query interval is set too low and we have multiple bridges or even a single bridge with multiple querier vlans configured we can crash the machine. Add a 1 second minimum which must be enforced by overwriting the value if set lower (i.e. without returning an error) to avoid breaking user-space. If that happens a log message is emitted to let the administrator know that the interval has been set to the minimum. The issue has been present since these intervals could be user-controlled. [1] https://lore.kernel.org/netdev/e8b9ce41-57b9-b6e2-a46a-ff9c791cf0ba@gmail.com/ Fixes: d902eee4 ("bridge: Add multicast count/interval sysfs entries") Reported-by:Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by:
Nikolay Aleksandrov <nikolay@nvidia.com> Signed-off-by:
Jakub Kicinski <kuba@kernel.org>
Showing
- net/bridge/br_multicast.c 16 additions, 0 deletionsnet/bridge/br_multicast.c
- net/bridge/br_netlink.c 1 addition, 1 deletionnet/bridge/br_netlink.c
- net/bridge/br_private.h 3 additions, 0 deletionsnet/bridge/br_private.h
- net/bridge/br_sysfs_br.c 1 addition, 1 deletionnet/bridge/br_sysfs_br.c
- net/bridge/br_vlan_options.c 1 addition, 1 deletionnet/bridge/br_vlan_options.c
Loading
Please register or sign in to comment