selftests/bpf: Turn on libbpf 1.0 mode and fix all IS_ERR checks
Turn ony libbpf 1.0 mode. Fix all the explicit IS_ERR checks that now will be broken because libbpf returns NULL on error (and sets errno). Fix ASSERT_OK_PTR and ASSERT_ERR_PTR to work for both old mode and new modes and use them throughout selftests. This is trivial to do by using libbpf_get_error() API that all libbpf users are supposed to use, instead of IS_ERR checks. A bunch of checks also did explicit -1 comparison for various fd-returning APIs. Such checks are replaced with >= 0 or < 0 cases. There were also few misuses of bpf_object__find_map_by_name() in test_maps. Those are fixed in this patch as well. Signed-off-by:Andrii Nakryiko <andrii@kernel.org> Signed-off-by:
Alexei Starovoitov <ast@kernel.org> Acked-by:
John Fastabend <john.fastabend@gmail.com> Acked-by:
Toke Høiland-Jørgensen <toke@redhat.com> Link: https://lore.kernel.org/bpf/20210525035935.1461796-3-andrii@kernel.org
Showing
- tools/testing/selftests/bpf/bench.c 1 addition, 0 deletionstools/testing/selftests/bpf/bench.c
- tools/testing/selftests/bpf/benchs/bench_rename.c 1 addition, 1 deletiontools/testing/selftests/bpf/benchs/bench_rename.c
- tools/testing/selftests/bpf/benchs/bench_ringbufs.c 3 additions, 3 deletionstools/testing/selftests/bpf/benchs/bench_ringbufs.c
- tools/testing/selftests/bpf/benchs/bench_trigger.c 1 addition, 1 deletiontools/testing/selftests/bpf/benchs/bench_trigger.c
- tools/testing/selftests/bpf/prog_tests/attach_probe.c 4 additions, 8 deletionstools/testing/selftests/bpf/prog_tests/attach_probe.c
- tools/testing/selftests/bpf/prog_tests/bpf_iter.c 14 additions, 17 deletionstools/testing/selftests/bpf/prog_tests/bpf_iter.c
- tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c 3 additions, 5 deletionstools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
- tools/testing/selftests/bpf/prog_tests/btf.c 47 additions, 46 deletionstools/testing/selftests/bpf/prog_tests/btf.c
- tools/testing/selftests/bpf/prog_tests/btf_dump.c 4 additions, 4 deletionstools/testing/selftests/bpf/prog_tests/btf_dump.c
- tools/testing/selftests/bpf/prog_tests/btf_write.c 1 addition, 3 deletionstools/testing/selftests/bpf/prog_tests/btf_write.c
- tools/testing/selftests/bpf/prog_tests/cg_storage_multi.c 28 additions, 56 deletionstools/testing/selftests/bpf/prog_tests/cg_storage_multi.c
- tools/testing/selftests/bpf/prog_tests/cgroup_attach_multi.c 1 addition, 1 deletiontools/testing/selftests/bpf/prog_tests/cgroup_attach_multi.c
- tools/testing/selftests/bpf/prog_tests/cgroup_link.c 5 additions, 9 deletionstools/testing/selftests/bpf/prog_tests/cgroup_link.c
- tools/testing/selftests/bpf/prog_tests/cgroup_skb_sk_lookup.c 1 addition, 1 deletion...s/testing/selftests/bpf/prog_tests/cgroup_skb_sk_lookup.c
- tools/testing/selftests/bpf/prog_tests/check_mtu.c 1 addition, 1 deletiontools/testing/selftests/bpf/prog_tests/check_mtu.c
- tools/testing/selftests/bpf/prog_tests/core_reloc.c 5 additions, 10 deletionstools/testing/selftests/bpf/prog_tests/core_reloc.c
- tools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c 8 additions, 17 deletionstools/testing/selftests/bpf/prog_tests/fexit_bpf2bpf.c
- tools/testing/selftests/bpf/prog_tests/flow_dissector.c 1 addition, 1 deletiontools/testing/selftests/bpf/prog_tests/flow_dissector.c
- tools/testing/selftests/bpf/prog_tests/flow_dissector_reattach.c 5 additions, 5 deletions...esting/selftests/bpf/prog_tests/flow_dissector_reattach.c
- tools/testing/selftests/bpf/prog_tests/get_stack_raw_tp.c 4 additions, 6 deletionstools/testing/selftests/bpf/prog_tests/get_stack_raw_tp.c
Loading
Please register or sign in to comment