Skip to content
Snippets Groups Projects
Commit ee1806be authored by Dafna Hirschfeld's avatar Dafna Hirschfeld Committed by Mauro Carvalho Chehab
Browse files

media: videobuf2: add WARN_ON_ONCE if bytesused is bigger than buffer length


In function vb2_set_plane_payload, report if the given bytesused is
bigger than the buffer size, and clamp it to the buffer size.

Signed-off-by: default avatarDafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 05fd87b8
No related branches found
No related tags found
No related merge requests found
......@@ -1155,8 +1155,15 @@ static inline void *vb2_get_drv_priv(struct vb2_queue *q)
static inline void vb2_set_plane_payload(struct vb2_buffer *vb,
unsigned int plane_no, unsigned long size)
{
if (plane_no < vb->num_planes)
/*
* size must never be larger than the buffer length, so
* warn and clamp to the buffer length if that's the case.
*/
if (plane_no < vb->num_planes) {
if (WARN_ON_ONCE(size > vb->planes[plane_no].length))
size = vb->planes[plane_no].length;
vb->planes[plane_no].bytesused = size;
}
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment