Skip to content
Snippets Groups Projects
  1. Aug 24, 2018
  2. Aug 21, 2018
  3. Aug 19, 2018
  4. Aug 16, 2018
    • Linus Torvalds's avatar
      ALSA: update dell-wmi mic-mute registration to new world order · 70b20dd7
      Linus Torvalds authored
      
      Commit c647f806 ("ALSA: hda - Allow multiple ADCs for mic mute LED
      controls") changed the return value of the snd_hda_gen_add_micmute_led()
      without actually updating the callers.
      
      Admittedly, almost no callers actually cared about the return value.
      But one call site very much did: the Dell wmi code.  It would see the
      registration return zero, which _used_ to mean "failed" but now means
      "success", and clear the dell_micmute_led_set_func pointer.
      
      End result: the successful registration would end up calling the Dell
      code that thought it had all failed, and call through a NULL pointer.
      
      To make matters worse, it ends up being a tail-call, and with the
      retpoline sequence you don't even see the caller (dell_micmute_update())
      in the stack trace, so the error ended up way less obvious than it
      should have been.
      
      Fixes: c647f806 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
      Cc: Takashi Iwai <tiwai@suse.de>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      70b20dd7
  5. Aug 14, 2018
  6. Aug 09, 2018
  7. Aug 08, 2018
  8. Aug 07, 2018
    • Srinivas Kandagatla's avatar
      ASoC: compress: make BE and FE order inline with dpcm · 0b0722e1
      Srinivas Kandagatla authored
      
      For some reason order of startup/hw_params/prepare are reversed
      in dynamic compress usecase when compared to dpcm usecase. This is
      a issue with platforms like QCOM where it expects the BE to be
      initialized before FE.
      
      Interestingly the compress trigger callback order is inline with dpcm.
      
      Am not 100% sure why the compress audio case has been reversed.
      This patch is making the order inline with dpcm.
      
      If the reverse ordering is just co-incendental then this change
      makes sense and will avoid inventing some new mechanism to cope
      with ordering.
      
      Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      0b0722e1
  9. Aug 06, 2018
Loading