Skip to content
Snippets Groups Projects
  1. Dec 11, 2020
  2. Nov 19, 2020
  3. Nov 13, 2020
    • Marc Kleine-Budde's avatar
      dt-bindings: clock: imx5: fix example · bdac39a3
      Marc Kleine-Budde authored
      
      Since commit:
      
          0e030a37 ("can: flexcan: fix endianess detection")
      
      the fsl,imx53-flexcan isn't compatible with the fsl,p1010-flexcan any more. As
      the former accesses the IP core in Little Endian mode and the latter uses Big
      Endian mode.
      
      With the conversion of the flexcan DT bindings to yaml, the dt_binding_check
      this throws the following error:
      
      Documentation/devicetree/bindings/clock/imx5-clock.example.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
      	['fsl,imx53-flexcan', 'fsl,p1010-flexcan'] is too long
      	Additional items are not allowed ('fsl,p1010-flexcan' was unexpected)
      	'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
      	'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
      	'fsl,imx6q-flexcan' was expected
      	'fsl,lx2160ar1-flexcan' was expected
      	From schema: /builds/robherring/linux-dt-bindings/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
      
      The error is fixed by replacing the "fsl,p1010-flexcan" compatible
      (which turned out the be incompatible) with "fsl,imx25-flexcan" in the
      binding example.
      
      Reported-by: default avatarRob Herring <robh+dt@kernel.org>
      Cc: Fabio Estevam <fabio.estevam@nxp.com>
      Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
      Link: https://lore.kernel.org/r/20201111213548.1621094-1-mkl@pengutronix.de
      
      
      [robh: Add "fsl,imx25-flexcan" as fallback]
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      bdac39a3
    • Marc Kleine-Budde's avatar
      dt-bindings: can: fsl,flexcan.yaml: fix compatible for i.MX35 and i.MX53 · 3bbb73f8
      Marc Kleine-Budde authored
      
      As both the i.MX35 and i.MX53 flexcan IP cores are compatible to the i.MX25,
      they are listed as:
      
          compatible = "fsl,imx35-flexcan", "fsl,imx25-flexcan";
      
      and:
      
          compatible = "fsl,imx53-flexcan", "fsl,imx25-flexcan";
      
      in the SoC device trees.
      
      This patch fixes the following errors, which shows up during a dtbs_check:
      
      arch/arm/boot/dts/imx53-ard.dt.yaml: can@53fc8000: compatible: 'oneOf' conditional failed, one must be fixed:
         ['fsl,imx53-flexcan', 'fsl,imx25-flexcan'] is too long
         Additional items are not allowed ('fsl,imx25-flexcan' was unexpected)
         'fsl,imx53-flexcan' is not one of ['fsl,imx7d-flexcan', 'fsl,imx6ul-flexcan', 'fsl,imx6sx-flexcan']
         'fsl,imx53-flexcan' is not one of ['fsl,ls1028ar1-flexcan']
         'fsl,imx6q-flexcan' was expected
         'fsl,lx2160ar1-flexcan' was expected
         From schema: Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
      
      Fixes: e5ab9aa7 ("dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml")
      Reported-by: default avatarRob Herring <robh+dt@kernel.org>
      Cc: Oleksij Rempel <o.rempel@pengutronix.de>
      Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
      Link: https://lore.kernel.org/r/20201111130507.1560881-4-mkl@pengutronix.de
      
      
      [robh: drop singular fsl,imx53-flexcan and fsl,imx35-flexcan]
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      3bbb73f8
  4. Nov 11, 2020
  5. Nov 05, 2020
  6. Nov 03, 2020
  7. Nov 01, 2020
  8. Oct 28, 2020
  9. Oct 26, 2020
  10. Oct 23, 2020
  11. Oct 20, 2020
    • Ard Biesheuvel's avatar
      netsec: ignore 'phy-mode' device property on ACPI systems · acd7aaf5
      Ard Biesheuvel authored
      
      Since commit bbc4d71d ("net: phy: realtek: fix rtl8211e rx/tx
      delay config"), the Realtek PHY driver will override any TX/RX delay
      set by hardware straps if the phy-mode device property does not match.
      
      This is causing problems on SynQuacer based platforms (the only SoC
      that incorporates the netsec hardware), since many were built with
      this Realtek PHY, and shipped with firmware that defines the phy-mode
      as 'rgmii', even though the PHY is configured for TX and RX delay using
      pull-ups.
      
      From the driver's perspective, we should not make any assumptions in
      the general case that the PHY hardware does not require any initial
      configuration. However, the situation is slightly different for ACPI
      boot, since it implies rich firmware with AML abstractions to handle
      hardware details that are not exposed to the OS. So in the ACPI case,
      it is reasonable to assume that the PHY comes up in the right mode,
      regardless of whether the mode is set by straps, by boot time firmware
      or by AML executed by the ACPI interpreter.
      
      So let's ignore the 'phy-mode' device property when probing the netsec
      driver in ACPI mode, and hardcode the mode to PHY_INTERFACE_MODE_NA,
      which should work with any PHY provided that it is configured by the
      time the driver attaches to it. While at it, document that omitting
      the mode is permitted for DT probing as well, by setting the phy-mode
      DT property to the empty string.
      
      Fixes: 533dd11a ("net: socionext: Add Synquacer NetSec driver")
      Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
      Reviewed-by: default avatarIlias Apalodimas <ilias.apalodimas@linaro.org>
      Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
      Link: https://lore.kernel.org/r/20201018163625.2392-1-ardb@kernel.org
      
      
      Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
      acd7aaf5
  12. Oct 19, 2020
  13. Oct 15, 2020
  14. Oct 14, 2020
  15. Oct 13, 2020
Loading